Add tests for panic and todo, fix test order for panic

Author: Licenser

clippy_lints/src/panic_unimplemented.rs

@@ -119,7 +119,6 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for PanicUnimplemented {
                     let span = get_outer_span(expr);
                     span_lint(cx, PANIC, span,
                               "`panic` should not be present in production code");
-                //} else {
                     match_panic(params, expr, cx);
                 }
             }

tests/ui/panic.rs

@@ -0,0 +1,12 @@
+#![warn(clippy::panic)]
+#![allow(clippy::assertions_on_constants)]
+
+fn panic() {
+    let a = 2;
+    panic!();
+    let b = a + 2;
+}
+
+fn main() {
+    panic();
+}

tests/ui/panic.stderr

@@ -0,0 +1,10 @@
+error: `panic` should not be present in production code
+  --> $DIR/panic.rs:6:5
+   |
+LL |     panic!();
+   |     ^^^^^^^^^
+   |
+   = note: `-D clippy::panic` implied by `-D warnings`
+
+error: aborting due to previous error
+

tests/ui/panic_unimplemented.rs

@@ -1,4 +1,4 @@
-#![warn(clippy::panic_params, clippy::unimplemented, clippy::unreachable)]
+#![warn(clippy::panic_params, clippy::unimplemented, clippy::unreachable, clippy::todo)]
 #![allow(clippy::assertions_on_constants)]
 fn missing() {
     if true {
@@ -78,4 +78,5 @@ fn main() {
     ok_escaped();
     unimplemented();
     unreachable();
+    todo();
 }

tests/ui/panic_unimplemented.stderr

@@ -40,5 +40,13 @@ LL |     unreachable!();
    |
    = note: `-D clippy::unreachable` implied by `-D warnings`
 
-error: aborting due to 6 previous errors
+error: `todo` should not be present in production code
+  --> $DIR/panic_unimplemented.rs:67:5
+   |
+LL |     todo!();
+   |     ^^^^^^^^
+   |
+   = note: `-D clippy::todo` implied by `-D warnings`
+
+error: aborting due to 7 previous errors