Merge #10688

10688: internal: Type-check TS on CI and also turn off the strict setting `useUnknownInCatchVariables` r=lnicola a=ChayimFriedman2

We don't follow it and I found that turning it on will have little benefit.

I'm not sure if we should also type-check when building in launch.json.

Co-authored-by: Chayim Refael Friedman <chayimfr@gmail.com>

Author: bors[bot]

.github/workflows/ci.yaml

@@ -132,5 +132,8 @@ jobs:
         run: npm --prefix ./editors/code test
         # working-directory: ./editors/code  # does not work: https://github.com/GabrielBB/xvfb-action/issues/8
 
+    - run: npm run pretest
+      working-directory: ./editors/code
+
     - run: npm run package --scripts-prepend-node-path
       working-directory: ./editors/code

editors/code/package-lock.json

@@ -32,7 +32,7 @@
         "watch": "npm run build-base -- --sourcemap --watch",
         "lint": "tsfmt --verify && eslint -c .eslintrc.js --ext ts ./src ./tests",
         "fix": " tsfmt -r       && eslint -c .eslintrc.js --ext ts ./src ./tests --fix",
-        "pretest": "tsc && npm run build",
+        "pretest": "tsc --noEmit && npm run build",
         "test": "node ./out/tests/runTests.js"
     },
     "dependencies": {

editors/code/package.json

@@ -9,6 +9,7 @@
         "sourceMap": true,
         "rootDir": ".",
         "strict": true,
+        "useUnknownInCatchVariables": false,
         "noUnusedLocals": true,
         "noUnusedParameters": true,
         "noImplicitReturns": true,