check self

Author: mustakimali

crates/ide-completion/src/completions.rs

@@ -297,6 +297,7 @@ impl Completions {
             Visible::No => return,
         };
         let doc_aliases = ctx.doc_aliases(&func);
+
         self.add(
             render_fn(
                 RenderContext::new(ctx)

crates/ide-completion/src/completions/expr.rs

@@ -120,7 +120,6 @@ pub(crate) fn complete_expr_path(
 
                     // XXX: For parity with Rust bug #22519, this does not complete Ty::AssocType.
                     // (where AssocType is defined on a trait, not an inherent impl)
-
                     ctx.iterate_path_candidates(&ty, |item| {
                         add_assoc_item(acc, item);
                     });

crates/ide-completion/src/item.rs

@@ -166,8 +166,8 @@ pub struct CompletionRelevance {
     pub postfix_match: Option<CompletionRelevancePostfixMatch>,
     /// This is set for type inference results
     pub is_definite: bool,
-    /// This is set for items that are constructors for the type of the impl/trait
-    pub associated_fn_type: Option<CompletionRelevanceAssociatedFnType>,
+    /// This is set for items that are associated functions
+    pub associated_fn: Option<CompletionRelevanceAssociatedFn>,
 }
 
 #[derive(Debug, Clone, Copy, Eq, PartialEq)]
@@ -209,13 +209,19 @@ pub enum CompletionRelevancePostfixMatch {
     Exact,
 }
 
+#[derive(Debug, Clone, Copy, Eq, PartialEq)]
+pub struct CompletionRelevanceAssociatedFn {
+    pub has_args: bool,
+    pub ty: CompletionRelevanceAssociatedFnType,
+}
+
 #[derive(Debug, Clone, Copy, Eq, PartialEq)]
 pub enum CompletionRelevanceAssociatedFnType {
+    Unknown,
     /// Returns a type that is expected in this context
     ReturnsExpectedType,
     /// Returns the Self type of the impl/trait
     DirectConstructor,
-    DirectConstructorWithArgs,
     /// Returns something that indirectly constructs the `Self` type of the impl/trait e.g. `Result<Self, ()>`, `Option<Self>`
     Constructor,
     /// Returns a possible builder for the type
@@ -246,7 +252,7 @@ impl CompletionRelevance {
             postfix_match,
             is_definite,
             is_item_from_notable_trait,
-            associated_fn_type: constructor_type,
+            associated_fn,
         } = self;
 
         // lower rank private things
@@ -292,14 +298,15 @@ impl CompletionRelevance {
             score += 10;
         }
 
-        score += match constructor_type {
-            Some(CompletionRelevanceAssociatedFnType::ReturnsExpectedType) => 5,
-            Some(CompletionRelevanceAssociatedFnType::DirectConstructor) => 4,
-            Some(CompletionRelevanceAssociatedFnType::DirectConstructorWithArgs) => 3,
-            Some(CompletionRelevanceAssociatedFnType::Builder) => 2,
-            Some(CompletionRelevanceAssociatedFnType::Constructor) => 1,
-            None => 0,
-        };
+        score += associated_fn
+            .map(|asf| match asf.ty {
+                CompletionRelevanceAssociatedFnType::ReturnsExpectedType => 20,
+                CompletionRelevanceAssociatedFnType::DirectConstructor => 15,
+                CompletionRelevanceAssociatedFnType::Builder => 10,
+                CompletionRelevanceAssociatedFnType::Constructor => 5,
+                CompletionRelevanceAssociatedFnType::Unknown => 0,
+            }  + if !asf.has_args { 5 } else { 0 })
+            .unwrap_or_default();
 
         score
     }

crates/ide-completion/src/render.rs

@@ -2027,54 +2027,62 @@ fn main() {
     fn colon_complete_preferred_order_relevances() {
         check_relevance(
             r#"
-struct A;
-struct ABuilder;
-impl A {
-    fn foo(&self) {}
-    fn new_1(input: u32) -> A { A }
-    fn new_2() -> Self { A }
-    fn aaaabuilder() -> ABuilder { A }
+struct AStruct;
+struct AStructBuilder;
+struct Result<T>(T);
+
+impl AStruct {
+    fn fn_no_ret(&self) {}
+    fn fn_ctr_with_args(input: u32) -> AStruct { AStruct }
+    fn fn_direct_ctr() -> Self { AStruct }
+    fn fn_ctr() -> Result<Self> { Result(AStruct) }
+    fn fn_other() -> Result<u32> { 0 }
+    fn fn_builder() -> AStructBuilder { AStructBuilder }
 }
 
 fn test() {
-    let a = A::$0;
+    let a = self::AStruct::$0;
 }
 "#,
             // preference:
-            // fn with no param that returns itself
-            // builder like fn
+            // Direct Constructor
+            // Direct Constructor with args
+            // Builder
+            // Constructor
             // fn with param that returns itself
             expect![[r#"
-                fn new_2() [type_could_unify]
-                fn aaaabuilder() [type_could_unify]
-                fn new_1(…) [type_could_unify]
-                me foo(…) [type_could_unify]
+                fn fn_direct_ctr() [type_could_unify]
+                fn fn_ctr_with_args(…) [type_could_unify]
+                fn fn_builder() [type_could_unify]
+                fn fn_ctr() [type_could_unify]
+                fn fn_other() [type_could_unify]
+                me fn_no_ret(…) [type_could_unify]
             "#]],
         );
 
-        // Generic
-        check_relevance(
-            r#"
-struct A<T>{item: T}
-struct ABuilder;
-impl A {
-    fn foo(&self) {}
-    fn new_1<T>(input: u32, l: T) -> A<T> { A }
-    fn new_2<T>() -> Self { A { item: <_>::default()} }
-    fn aaaabuilder<T>() -> ABuilder<T> { A }
-}
-
-fn test() {
-    let a = A::$0;
-}
-"#,
-            expect![[r#"
-                fn new_2() [type_could_unify]
-                fn aaaabuilder() [type_could_unify]
-                fn new_1(…) [type_could_unify]
-                me foo(…) [type_could_unify]
-            "#]],
-        );
+        //         // Generic
+        //         check_relevance(
+        //             r#"
+        // struct A<T>{item: T}
+        // struct ABuilder;
+        // impl A {
+        //     fn foo(&self) {}
+        //     fn new_1<T>(input: u32, l: T) -> A<T> { A }
+        //     fn new_2<T>() -> Self { A { item: <_>::default()} }
+        //     fn aaaabuilder<T>() -> ABuilder<T> { A }
+        // }
+
+        // fn test() {
+        //     let a = A::$0;
+        // }
+        // "#,
+        //             expect![[r#"
+        //                 fn new_2() [type_could_unify]
+        //                 fn aaaabuilder() [type_could_unify]
+        //                 fn new_1(…) [type_could_unify]
+        //                 me foo(…) [type_could_unify]
+        //             "#]],
+        //         );
     }
 
     #[test]

crates/ide-completion/src/render/function.rs

@@ -7,10 +7,12 @@ use stdx::{format_to, to_lower_snake_case};
 use syntax::{AstNode, SmolStr};
 
 use crate::{
-    context::{CompletionContext, DotAccess, DotAccessKind, PathCompletionCtx, PathKind},
+    context::{
+        CompletionContext, DotAccess, DotAccessKind, PathCompletionCtx, PathKind, Qualified,
+    },
     item::{
         Builder, CompletionItem, CompletionItemKind, CompletionRelevance,
-        CompletionRelevanceAssociatedFnType,
+        CompletionRelevanceAssociatedFn, CompletionRelevanceAssociatedFnType,
     },
     render::{compute_exact_name_match, compute_ref_match, compute_type_match, RenderContext},
     CallableSnippets,
@@ -110,9 +112,9 @@ fn render(
             compute_type_match(completion, &func.ty(db))
         },
         exact_name_match: compute_exact_name_match(completion, &call),
+        associated_fn: compute_associated_fn(&ctx, func, &func_kind, db),
         is_op_method,
         is_item_from_notable_trait,
-        associated_fn_type: compute_constructor_type(&ctx, func, db),
         ..ctx.completion_relevance()
     });
 
@@ -161,36 +163,50 @@ fn render(
     item
 }
 
-fn compute_constructor_type(
+fn compute_associated_fn(
     ctx: &RenderContext<'_>,
     func: hir::Function,
+    func_kind: &FuncKind<'_>,
     db: &dyn HirDatabase,
-) -> Option<CompletionRelevanceAssociatedFnType> {
+) -> Option<CompletionRelevanceAssociatedFn> {
     if func.as_assoc_item(ctx.db()).is_none() {
         return None;
     }
 
-    let has_args = !func.assoc_fn_params(db).is_empty();
     let ret_type = func.ret_type(db);
+    let self_ty = match func_kind {
+        FuncKind::Function(PathCompletionCtx {
+            qualified: Qualified::With { path, .. }, ..
+        }) => path.segment().map(|s| s.to_string()),
+        _ => None,
+    };
+    let (returns_self, returns_self_wrapped) = self_ty
+        .map(|self_ty| {
+            let ret_ty = ret_type.display(db).to_string();
+            let ret_self_wrapped = ret_ty.contains(&format!("<{self_ty}>"));
 
-    dbg!(&ret_type, &func, &ctx);
+            (ret_ty == self_ty || ret_self_wrapped, ret_self_wrapped)
+        })
+        .unwrap_or_else(|| (false, false));
 
-    if ctx.completion.expected_type.as_ref() == Some(&ret_type) {
+    let ty = if !returns_self && ctx.completion.expected_type.as_ref() == Some(&ret_type) {
         // impl Foo { fn baz(&self) -> u32 { 0 } }
         // let _: u32 = foo.$0; // baz is preffered as it returns expected u32
-        Some(CompletionRelevanceAssociatedFnType::ReturnsExpectedType)
-    } else if !has_args && !ret_type.is_unit() {
-        // fn() -> A
-        Some(CompletionRelevanceAssociatedFnType::DirectConstructor)
-    } else if has_args && !ret_type.is_unit() {
-        // fn(..) -> A
-        Some(CompletionRelevanceAssociatedFnType::DirectConstructorWithArgs)
-    } else if !has_args && ret_type.display(db).to_string().ends_with("Builder") {
+        CompletionRelevanceAssociatedFnType::ReturnsExpectedType
+    } else if ret_type.display(db).to_string().ends_with("Builder") {
         // -> [..]Builder
-        Some(CompletionRelevanceAssociatedFnType::Builder)
+        CompletionRelevanceAssociatedFnType::Builder
+    } else if returns_self_wrapped {
+        // fn() -> Result<A>
+        CompletionRelevanceAssociatedFnType::Constructor
+    } else if returns_self {
+        // fn() -> A
+        CompletionRelevanceAssociatedFnType::DirectConstructor
     } else {
-        None
-    }
+        CompletionRelevanceAssociatedFnType::Unknown
+    };
+
+    Some(CompletionRelevanceAssociatedFn { ty, has_args: !func.assoc_fn_params(db).is_empty() })
 }
 
 pub(super) fn add_call_parens<'b>(