Fix scoring logic in CompletionRelevance

mustakimali · mustakimali · commit 7bbd8526b7c3 · 2024-01-15T22:43:00.000Z
diff --git a/crates/ide-completion/src/item.rs b/crates/ide-completion/src/item.rs
@@ -312,7 +312,7 @@ impl CompletionRelevance {
                 // Prefer functions with no arguments, then functions with self arguments
                 if score > 0 {
                     score += if !asf.has_args { 2 } else { 0 };
-                    score -= if asf.has_self_arg { 1 } else { 0 };
+                    score -= if asf.has_self_arg { score - 1 } else { 0 };
                 }
 
                 score

Original file line number	Diff line number	Diff line change
`@@ -312,7 +312,7 @@ impl CompletionRelevance {`
`312`	`312`	`// Prefer functions with no arguments, then functions with self arguments`
`313`	`313`	`if score > 0 {`
`314`	`314`	`score += if !asf.has_args { 2 } else { 0 };`
`315`		`- score -= if asf.has_self_arg { 1 } else { 0 };`
	`315`	`+ score -= if asf.has_self_arg { score - 1 } else { 0 };`
`316`	`316`	`}`
`317`	`317`
`318`	`318`	`score`