Require that test names be valid rust identifiers

Author: casey

text/0000-doctest-name.md

@@ -6,8 +6,8 @@
 # Summary
 [summary]: #summary
 
-Allow giving documentation tests names for identification in test runner
-output by including `name=NAME` in doctest code block info strings.
+Allow giving documentation tests names for identification in test runner output
+by including `name=IDENT` in doctest code block info strings.
 
 # Motivation
 [motivation]: #motivation
@@ -24,8 +24,8 @@ specific tests using `cargo test --doc -- $TEST_NAME`.
 # Guide-level explanation
 [guide-level-explanation]: #guide-level-explanation
 
-Doctests are written as fenced markdown code blocks that start and end
-with lines containing three backticks.
+Doctests are written as fenced markdown code blocks that start and end with
+lines containing three backticks.
 
 The first set of backticks may be followed by an info string. For example, to
 tell the Rust compiler to ignore the doctest:
@@ -52,8 +52,9 @@ test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
 ```
 
 If you'd like to have the test runner print a more informative name, perhaps
-because there are many doctests in a single file, you can put `name=NAME`,
-where `NAME` is the name the test should have, in the doctest's info string.
+because there are many doctests in a single file, you can put `name=IDENT`,
+where `IDENT` is the name the test should have, which must be an identifier, in
+the doctest's info string.
 
 
 ````rust
@@ -77,18 +78,18 @@ test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out
 [reference-level-explanation]: #reference-level-explanation
 
 The set of valid words that may appear in code block info strings is extended
-to include patterns of the form `name=NAME`.
+to include patterns of the form `name=IDENT`.
 
-This `NAME` will be the name of the documentation test generated by the code
-block.
+This `IDENT` will be the name of the documentation test generated by the code
+block, and must be a valid Rust identifier.
 
 When the test runner runs the documentation test, the test will be identified
 by this name, in addition to the test binary, module, and line number.
 
-Multiple `name=NAME` words may not appear in a single code block's info
+Multiple `name=IDENT` words may not appear in a single code block's info
 string.
 
-`name=NAME` may be combined with existing annotations like `rust` or
+`name=IDENT` may be combined with existing annotations like `rust` or
 `should_panic` by separating the annotations with commas:
 
 ````
@@ -116,13 +117,6 @@ feature.
 This design seems like the simplest design possible, although viable
 alternatives may have been overlooked.
 
-A previous version of this RFC included the additional restrictions that labels
-must be valid rust identifiers, and that labels must be unique within the same
-module. These restrictions were intended to allow the machinery that generates
-doctest tests to use the labels as the generated doctest function names. If
-this simplifies or improves the generated doctest functions, these restrictions
-might be desirable.
-
 The impact of adopting this RFC is minimal. Doctests test output will remain a
 little hard to make sense of.