Skip to content

Commit 160fbae

Browse files
tmandryMark-Simulacrum
authored andcommitted
Add reviews_{requested,given} to /api/<username>
This helps a user prioritize their requests by seeing how close each of them is to being accepted.
1 parent 20ee406 commit 160fbae

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

src/nag.rs

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,8 @@ pub struct IndividualFcp {
9090
issue: Issue,
9191
proposal: FcpProposal,
9292
review_request: FcpReviewRequest,
93+
reviews_given: i32,
94+
reviews_requested: i32,
9395
}
9496

9597
pub fn individual_nags(username: &str) -> DashResult<(GitHubUser, Vec<IndividualFcp>)> {
@@ -113,10 +115,18 @@ pub fn individual_nags(username: &str) -> DashResult<(GitHubUser, Vec<Individual
113115
.filter(issue::id.eq(proposal.fk_issue))
114116
.first::<Issue>(conn)?;
115117

118+
let reviews = fcp_review_request::table
119+
.filter(fcp_review_request::fk_proposal.eq(proposal.id))
120+
.load::<FcpReviewRequest>(conn)?;
121+
let reviews_given = reviews.iter().filter(|r| r.reviewed).count() as i32;
122+
let reviews_requested = reviews.len() as i32;
123+
116124
fcps.push(IndividualFcp {
117125
issue,
118126
proposal,
119127
review_request: rr,
128+
reviews_given,
129+
reviews_requested,
120130
});
121131
}
122132

0 commit comments

Comments
 (0)