Change how test suite filters tests

Author: shilangyu

regex-automata/tests/dfa/suite.rs

@@ -289,20 +289,16 @@ fn compiler(
                 }
             }
         }
+        // Or look-around expressions.
+        for hir in hirs.iter() {
+            if hir.properties().contains_lookaround_expr() {
+                return Ok(CompiledRegex::skip());
+            }
+        }
         if !configure_regex_builder(test, &mut builder) {
             return Ok(CompiledRegex::skip());
         }
-        let re = match builder.build_many(regexes) {
-            Ok(re) => re,
-            Err(err)
-                if test.compiles()
-                    && format!("{err}").contains("look-around") =>
-            {
-                return Ok(CompiledRegex::skip());
-            }
-            Err(err) => return Err(err.into()),
-        };
-        create_matcher(&builder, pre, re)
+        create_matcher(&builder, pre, builder.build_many(regexes)?)
     }
 }
 

regex-automata/tests/hybrid/suite.rs

@@ -180,19 +180,16 @@ fn compiler(
                 }
             }
         }
+        // Or look-around expressions.
+        for hir in hirs.iter() {
+            if hir.properties().contains_lookaround_expr() {
+                return Ok(CompiledRegex::skip());
+            }
+        }
         if !configure_regex_builder(test, &mut builder) {
             return Ok(CompiledRegex::skip());
         }
-        let re = match builder.build_many(regexes) {
-            Ok(re) => re,
-            Err(err)
-                if test.compiles()
-                    && format!("{err}").contains("look-around") =>
-            {
-                return Ok(CompiledRegex::skip());
-            }
-            Err(err) => return Err(err.into()),
-        };
+        let re = builder.build_many(&regexes)?;
         let mut cache = re.create_cache();
         Ok(CompiledRegex::compiled(move |test| -> TestResult {
             run_test(&re, &mut cache, test)

regex-automata/tests/nfa/thompson/backtrack/suite.rs

@@ -74,7 +74,7 @@ fn min_visited_capacity() -> Result<()> {
                 .configure(config_thompson(test))
                 .syntax(config_syntax(test))
                 .build_many(&regexes)?;
-            // TODO: remove once look-around is supported.
+            // The backtracker doesn't support lookarounds, so skip if there are any.
             if nfa.lookaround_count() > 0 {
                 return Ok(CompiledRegex::skip());
             }
@@ -109,7 +109,7 @@ fn compiler(
             return Ok(CompiledRegex::skip());
         }
         let re = builder.build_many(&regexes)?;
-        // TODO: remove once look-around is supported.
+        // The backtracker doesn't support lookarounds, so skip if there are any.
         if re.get_nfa().lookaround_count() > 0 {
             return Ok(CompiledRegex::skip());
         }