Apply suggestions from code review

Co-authored-by: Oli Scherer <github35764891676564198441@oli-obk.de>

Author: nia-e

src/alloc/isolated_alloc.rs

@@ -271,7 +271,7 @@ impl IsolatedAlloc {
     pub fn pages(&self) -> Vec<usize> {
         let mut pages: Vec<_> =
             self.page_ptrs.clone().into_iter().map(|p| p.expose_provenance()).collect();
-        self.huge_ptrs.iter().for_each(|(ptr, size)| {
+        for (ptr, size) in &self.huge_ptrs {
             for i in 0..size / self.page_size {
                 pages.push(unsafe { ptr.add(i * self.page_size).expose_provenance() });
             }

src/shims/trace/child.rs

@@ -6,9 +6,9 @@ use nix::sys::{ptrace, signal};
 use nix::unistd;
 
 use crate::alloc::isolated_alloc::IsolatedAlloc;
-use crate::shims::trace::messages::{Confirmation, MemEvents, TraceRequest};
-use crate::shims::trace::parent::{ChildListener, sv_loop};
-use crate::shims::trace::{FAKE_STACK_SIZE, StartFfiInfo};
+use super::messages::{Confirmation, MemEvents, TraceRequest};
+use super::parent::{ChildListener, sv_loop};
+use super::{FAKE_STACK_SIZE, StartFfiInfo};
 
 static SUPERVISOR: std::sync::Mutex<Option<Supervisor>> = std::sync::Mutex::new(None);
 

src/shims/trace/parent.rs

@@ -2,8 +2,8 @@ use ipc_channel::ipc;
 use nix::sys::{ptrace, signal, wait};
 use nix::unistd;
 
-use crate::shims::trace::StartFfiInfo;
-use crate::shims::trace::messages::{Confirmation, MemEvents, TraceRequest};
+use super::StartFfiInfo;
+use super::messages::{Confirmation, MemEvents, TraceRequest};
 
 /// The flags to use when calling `waitid()`.
 /// Since bitwise or on the nix version of these flags is implemented as a trait,