address review

Author: nia-e

no_alloc

@@ -0,0 +1,46 @@
+{
+  "backtraces": {
+    "mean": 2.3829520464,
+    "stddev": 0.07651981051526706
+  },
+  "big-allocs": {
+    "mean": 0.1673647059473684,
+    "stddev": 0.013478818300072831
+  },
+  "mse": {
+    "mean": 0.8133679916000001,
+    "stddev": 0.050075600632164104
+  },
+  "range-iteration": {
+    "mean": 4.243566763599999,
+    "stddev": 0.03380701243732224
+  },
+  "serde1": {
+    "mean": 2.589135003,
+    "stddev": 0.0700829518878718
+  },
+  "serde2": {
+    "mean": 5.955532229,
+    "stddev": 0.20599769835375004
+  },
+  "slice-chunked": {
+    "mean": 0.4702839168333333,
+    "stddev": 0.017522346103318015
+  },
+  "slice-get-unchecked": {
+    "mean": 0.8169163450000001,
+    "stddev": 0.013873697449548328
+  },
+  "string-replace": {
+    "mean": 0.5258388794,
+    "stddev": 0.032950972318742694
+  },
+  "unicode": {
+    "mean": 3.4562345727999997,
+    "stddev": 0.11276913990962134
+  },
+  "zip-equal": {
+    "mean": 3.0626452212,
+    "stddev": 0.0554291549675083
+  }
+}

src/alloc/isolated_alloc.rs

@@ -333,9 +333,12 @@ mod tests {
         }
     }
 
-    /// Checks that allocations of different sizes do not overlap. Not a freestanding
-    /// test because we use it as part of `check_leaks()` also.
-    fn no_overlaps(alloc: &mut IsolatedAlloc) {
+    /// Checks that allocations of different sizes do not overlap, then for memory
+    /// leaks that might have occurred.
+    #[test]
+    fn check_leaks_and_overlaps() {
+        let mut alloc = IsolatedAlloc::new();
+
         // Some random sizes and aligns
         let mut sizes = vec![32; 10];
         sizes.append(&mut vec![15; 4]);
@@ -374,16 +377,8 @@ mod tests {
                 alloc.dealloc(ptr, layout);
             }
         }
-    }
-
-    /// Check for memory leaks after repeated allocations and deallocations.
-    #[test]
-    fn check_leaks() {
-        let mut alloc = IsolatedAlloc::new();
-        // Generate some noise first so leaks can manifest
-        no_overlaps(&mut alloc);
 
-        // And then verify that no memory was leaked
+        // And then verify that no memory was leaked after all that
         assert!(alloc.page_ptrs.is_empty() && alloc.huge_ptrs.is_empty());
     }
 }

src/concurrency/thread.rs

@@ -906,7 +906,7 @@ pub trait EvalContextExt<'tcx>: crate::MiriInterpCxExt<'tcx> {
                     interp_ok(MiriAllocBytes::from_bytes(
                         std::borrow::Cow::Borrowed(bytes),
                         align,
-                        params.clone(),
+                        params,
                     ))
                 },
                 |ptr| this.global_root_pointer(ptr),