Auto merge of #1492 - RalfJung:rustup, r=RalfJung

Rustup

Adjusting for @oli-obk' log changes.

While at it I also removed the `*_of_val` intrinsics that got moved to rustc (Cc @ecstatic-morse).

Author: bors

rust-version

@@ -1 +1 @@
-1454bbd4fdac9b7272b93fe82860613dccc0afad
+21867225a74d3b07c2b65e32c67f45197db36896

src/diagnostics.rs

@@ -137,8 +137,7 @@ pub fn report_error<'tcx, 'mir>(
                 access.uninit_ptr.offset.bytes(),
                 access.uninit_ptr.offset.bytes() + access.uninit_size.bytes(),
             );
-            ecx.memory.dump_alloc(access.uninit_ptr.alloc_id);
-            eprintln!();
+            eprintln!("{:?}", ecx.memory.dump_alloc(access.uninit_ptr.alloc_id));
         }
         _ => {}
     }

src/shims/foreign_items.rs

@@ -1,5 +1,7 @@
 use std::{convert::{TryInto, TryFrom}, iter};
 
+use log::trace;
+
 use rustc_hir::def_id::DefId;
 use rustc_middle::{mir, ty};
 use rustc_target::abi::{Align, Size};
@@ -175,7 +177,7 @@ pub trait EvalContextExt<'mir, 'tcx: 'mir>: crate::MiriEvalContextExt<'mir, 'tcx
 
         // Third: functions that return.
         if this.emulate_foreign_item_by_name(link_name, args, dest, ret)? {
-            this.dump_place(*dest);
+            trace!("{:?}", this.dump_place(*dest));
             this.go_to_block(ret);
         }
 

src/shims/intrinsics.rs

@@ -1,5 +1,7 @@
 use std::iter;
 
+use log::trace;
+
 use rustc_attr as attr;
 use rustc_ast::ast::FloatTy;
 use rustc_middle::{mir, ty};
@@ -482,24 +484,6 @@ pub trait EvalContextExt<'mir, 'tcx: 'mir>: crate::MiriEvalContextExt<'mir, 'tcx
                 }
             }
 
-            "min_align_of_val" => {
-                let &[mplace] = check_arg_count(args)?;
-                let mplace = this.deref_operand(mplace)?;
-                let (_, align) = this
-                    .size_and_align_of_mplace(mplace)?
-                    .expect("size_of_val called on extern type");
-                this.write_scalar(Scalar::from_machine_usize(align.bytes(), this), dest)?;
-            }
-
-            "size_of_val" => {
-                let &[mplace] = check_arg_count(args)?;
-                let mplace = this.deref_operand(mplace)?;
-                let (size, _) = this
-                    .size_and_align_of_mplace(mplace)?
-                    .expect("size_of_val called on extern type");
-                this.write_scalar(Scalar::from_machine_usize(size.bytes(), this), dest)?;
-            }
-
             // Other
             "assume" => {
                 let &[cond] = check_arg_count(args)?;
@@ -524,7 +508,7 @@ pub trait EvalContextExt<'mir, 'tcx: 'mir>: crate::MiriEvalContextExt<'mir, 'tcx
             name => throw_unsup_format!("unimplemented intrinsic: {}", name),
         }
 
-        this.dump_place(*dest);
+        trace!("{:?}", this.dump_place(*dest));
         this.go_to_block(ret);
         Ok(())
     }

src/shims/posix/macos/dlsym.rs

@@ -1,5 +1,7 @@
 use rustc_middle::mir;
 
+use log::trace;
+
 use crate::*;
 use helpers::check_arg_count;
 
@@ -42,7 +44,7 @@ pub trait EvalContextExt<'mir, 'tcx: 'mir>: crate::MiriEvalContextExt<'mir, 'tcx
             }
         }
 
-        this.dump_place(*dest);
+        trace!("{:?}", this.dump_place(*dest));
         this.go_to_block(ret);
         Ok(())
     }

src/shims/windows/dlsym.rs

@@ -1,5 +1,7 @@
 use rustc_middle::mir;
 
+use log::trace;
+
 use crate::*;
 use helpers::check_arg_count;
 use shims::windows::sync::EvalContextExt as _;
@@ -73,7 +75,7 @@ pub trait EvalContextExt<'mir, 'tcx: 'mir>: crate::MiriEvalContextExt<'mir, 'tcx
             }
         }
 
-        this.dump_place(*dest);
+        trace!("{:?}", this.dump_place(*dest));
         this.go_to_block(ret);
         Ok(())
     }