Address nits in paged serialization implementation.

Author: michaelwoerister

measureme/src/profiler.rs

@@ -25,7 +25,7 @@ impl Profiler {
         // The first thing in the file must be the top-level file header.
         write_file_header(&mut file, FILE_MAGIC_TOP_LEVEL)?;
 
-        let sink_builder = SerializationSinkBuilder::from_file(file)?;
+        let sink_builder = SerializationSinkBuilder::new_from_file(file)?;
         let event_sink = Arc::new(sink_builder.new_sink(PageTag::Events));
 
         // The first thing in every stream we generate must be the stream header.

measureme/src/serialization.rs

@@ -88,7 +88,7 @@ pub struct SerializationSink {
 pub struct SerializationSinkBuilder(SharedState);
 
 impl SerializationSinkBuilder {
-    pub fn from_file(file: fs::File) -> Result<Self, Box<dyn Error + Send + Sync>> {
+    pub fn new_from_file(file: fs::File) -> Result<Self, Box<dyn Error + Send + Sync>> {
         Ok(Self(SharedState(Arc::new(Mutex::new(
             BackingStorage::File(file),
         )))))
@@ -399,7 +399,7 @@ impl SerializationSink {
         curr_addr
     }
 
-    pub fn as_std_write<'a>(&'a self) -> StdWriteAdapter<'a> {
+    pub fn as_std_write<'a>(&'a self) -> impl Write + 'a {
         StdWriteAdapter(self)
     }
 }