Some minor corrections from code review.

ehuss · ehuss · commit 4749f9d97a7a · 2023-09-02T16:41:59.000-07:00
diff --git a/guide/src/format/configuration/general.md b/guide/src/format/configuration/general.md
@@ -48,7 +48,7 @@ This is general information about your book.
 - **language:** The main language of the book, which is used as a language attribute `<html lang="en">` for example.
   This is also used to derive the direction of text (RTL, LTR) within the book.
 - **text_direction**: The direction of text in the book: Left-to-right (LTR) or Right-to-left (RTL). Possible values: `ltr`, `rtl`.
-  When not specified, the correct text direction is derived from the book's `language` attribute.
+  When not specified, the text direction is derived from the book's `language` attribute.
 
 **book.toml**
 ```toml
diff --git a/src/config.rs b/src/config.rs
@@ -412,7 +412,7 @@ pub struct BookConfig {
     /// The main language of the book.
     pub language: Option<String>,
     /// The direction of text in the book: Left-to-right (LTR) or Right-to-left (RTL).
-    /// When not specified, the correct text direction is derived from [BookConfig::language].
+    /// When not specified, the text direction is derived from [`BookConfig::language`].
     pub text_direction: Option<TextDirection>,
 }
 
@@ -431,13 +431,13 @@ impl Default for BookConfig {
 }
 
 impl BookConfig {
-    /// Gets the realized text direction, either from [BookConfig::text_direction]
-    /// or derived from [BookConfig::language], to be used by templating engines.
+    /// Gets the realized text direction, either from [`BookConfig::text_direction`]
+    /// or derived from [`BookConfig::language`], to be used by templating engines.
     pub fn realized_text_direction(&self) -> TextDirection {
         if let Some(direction) = self.text_direction {
             direction
         } else {
-            TextDirection::from_lang_code(&self.language.clone().unwrap_or_default())
+            TextDirection::from_lang_code(self.language.as_deref().unwrap_or_default())
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -412,7 +412,7 @@ pub struct BookConfig {`
`412`	`412`	`/// The main language of the book.`
`413`	`413`	`pub language: Option<String>,`
`414`	`414`	`/// The direction of text in the book: Left-to-right (LTR) or Right-to-left (RTL).`
`415`		`- /// When not specified, the correct text direction is derived from [BookConfig::language].`
	`415`	+ /// When not specified, the text direction is derived from [`BookConfig::language`].
`416`	`416`	`pub text_direction: Option<TextDirection>,`
`417`	`417`	`}`
`418`	`418`
`@@ -431,13 +431,13 @@ impl Default for BookConfig {`
`431`	`431`	`}`
`432`	`432`
`433`	`433`	`impl BookConfig {`
`434`		`- /// Gets the realized text direction, either from [BookConfig::text_direction]`
`435`		`- /// or derived from [BookConfig::language], to be used by templating engines.`
	`434`	+ /// Gets the realized text direction, either from [`BookConfig::text_direction`]
	`435`	+ /// or derived from [`BookConfig::language`], to be used by templating engines.
`436`	`436`	`pub fn realized_text_direction(&self) -> TextDirection {`
`437`	`437`	`if let Some(direction) = self.text_direction {`
`438`	`438`	`direction`
`439`	`439`	`} else {`
`440`		`- TextDirection::from_lang_code(&self.language.clone().unwrap_or_default())`
	`440`	`+ TextDirection::from_lang_code(self.language.as_deref().unwrap_or_default())`
`441`	`441`	`}`
`442`	`442`	`}`
`443`	`443`	`}`