-
Notifications
You must be signed in to change notification settings - Fork 21
Added very basic JUnit output #16
base: master
Are you sure you want to change the base?
Conversation
|
Just wanted to say that I'm excited about JUnit format potentially being added! FWIW, In my experience the JUnit result files emitted by cargo-junit seem to be "correct", at least in the sense that various CI engines are able to correctly parse/understand those JUnit files (albeit with missing timestamps). Sharing in case that's of any use as a comparison point |
|
Thank you! I'll make sure to compare those |
|
I'm curious as to why the timings for the tests aren't recorded? Most test frameworks I've worked with reports duration of tests OOTB, and I don't see a good reason for libtest to not do so. |
|
The main reason is that Nobody has sent a PR implementing that.
|
|
+1 on this! I'd love to see this PR merged, especially since we have |
|
Testing the output against some CI framework will be nice, but I think that this is repo is semi-dead for some reason. (no commits or merges since april) We should probably find the maintainer somewhere else. Edit: In another PR it is mentioned that this repo is actually not the crate that is distributed with Rust. @iostat It's probably needed to retarget this PR against the rustc codebase, but unfortunately I no longer have leisure to do so. If you could do it, I think it would be great. |
|
+1 on this as well. I'm eagerly awaiting a built in exporter to junit rather than an ad-hoc one. |
|
Hey guys, any chance we can get this effort going again? I think it'd be quite convenient to have this in. |
This PR adds a very basic JUnit formatter, and should probably not be merged without further discussion.
This output format is widely used, but sadly is not standardized.
The best summary I could find is was in Catch's website.
Some talk points:
Thoughts?