Merge pull request #4525 from xingxue-ibm/no-cast-for-c_char

Cast to `c_char` rather than `i8`

Author: tgross35

ctest-next/templates/test.rs

@@ -56,8 +56,7 @@ mod generated_tests {
         let val = {{ ident }};
         unsafe {
             let ptr = *__test_const_{{ ident }}();
-            // c_char can be i8 or u8, so just cast to i8.
-            let val = CStr::from_ptr(ptr.cast::<i8>());
+            let val = CStr::from_ptr(ptr.cast::<c_char>());
             let val = val.to_str().expect("const {{ ident }} not utf8");
             let c = ::std::ffi::CStr::from_ptr(ptr as *const _);
             let c = c.to_str().expect("const {{ ident }} not utf8");

ctest-next/tests/input/simple.out.rs

@@ -49,8 +49,7 @@ mod generated_tests {
         let val = A;
         unsafe {
             let ptr = *__test_const_A();
-            // c_char can be i8 or u8, so just cast to i8.
-            let val = CStr::from_ptr(ptr.cast::<i8>());
+            let val = CStr::from_ptr(ptr.cast::<c_char>());
             let val = val.to_str().expect("const A not utf8");
             let c = ::std::ffi::CStr::from_ptr(ptr as *const _);
             let c = c.to_str().expect("const A not utf8");