ci/style.rs: Catch derives of Copy and Clone

joshtriplett · joshtriplett · commit 6b52ae154480 · 2020-08-19T23:03:28.000-07:00
Let's prevent this from happening again.
diff --git a/ci/style.rs b/ci/style.rs
@@ -134,6 +134,9 @@ fn check_style(file: &str, path: &Path, err: &mut Errors) {
                                     instead of #[cfg]");
             }
         }
+        if line.contains("#[derive(") && (line.contains("Copy") || line.contains("Clone")) {
+            err.error(path, i, "impl ::Copy and ::Clone manually");
+        }
 
         let line = line.trim_start();
         let is_pub = line.starts_with("pub ");

Original file line number	Diff line number	Diff line change
`@@ -134,6 +134,9 @@ fn check_style(file: &str, path: &Path, err: &mut Errors) {`
`134`	`134`	`instead of #[cfg]");`
`135`	`135`	`}`
`136`	`136`	`}`
	`137`	`+ if line.contains("#[derive(") && (line.contains("Copy") \|\| line.contains("Clone")) {`
	`138`	`+ err.error(path, i, "impl ::Copy and ::Clone manually");`
	`139`	`+ }`
`137`	`140`
`138`	`141`	`let line = line.trim_start();`
`139`	`142`	`let is_pub = line.starts_with("pub ");`