Skip to content

Commit 4f1c07b

Browse files
lvllvltgross35
lvllvl
authored and
tgross35
committed
Chore: add labels to each FIXME
(backport <#4229>) (cherry picked from commit 6b8535b)
1 parent 91d0a1d commit 4f1c07b

File tree

12 files changed

+30
-30
lines changed

12 files changed

+30
-30
lines changed

‎src/unix/linux_like/linux/gnu/b64/aarch64/mod.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -601,7 +601,7 @@ pub const HWCAP_SSBS: c_ulong = 1 << 28;
601601
pub const HWCAP_SB: c_ulong = 1 << 29;
602602
pub const HWCAP_PACA: c_ulong = 1 << 30;
603603
pub const HWCAP_PACG: c_ulong = 1 << 31;
604-
// FIXME: enable these again once linux-api-headers are up to date enough on CI.
604+
// FIXME(linux): enable these again once linux-api-headers are up to date enough on CI.
605605
// See discussion in https://github.com/rust-lang/libc/pull/1638
606606
//pub const HWCAP2_DCPODP: c_ulong = 1 << 0;
607607
//pub const HWCAP2_SVE2: c_ulong = 1 << 1;

‎src/unix/linux_like/linux/gnu/b64/s390x.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ s! {
212212
}
213213

214214
s_no_extra_traits! {
215-
// FIXME: This is actually a union.
215+
// FIXME(union): This is actually a union.
216216
pub struct fpreg_t {
217217
pub d: c_double,
218218
// f: c_float,

‎src/unix/linux_like/linux/gnu/b64/x86_64/mod.rs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,7 @@ s_no_extra_traits! {
308308
pub uc_mcontext: mcontext_t,
309309
pub uc_sigmask: crate::sigset_t,
310310
__private: [u8; 512],
311-
// FIXME: the shadow stack field requires glibc >= 2.28.
311+
// FIXME(linux): the shadow stack field requires glibc >= 2.28.
312312
// Re-add once we drop compatibility with glibc versions older than
313313
// 2.28.
314314
//
@@ -357,7 +357,7 @@ cfg_if! {
357357
.field("mxcsr", &self.mxcsr)
358358
.field("mxcr_mask", &self.mxcr_mask)
359359
.field("st_space", &self.st_space)
360-
// FIXME: .field("xmm_space", &self.xmm_space)
360+
// FIXME(debug): .field("xmm_space", &self.xmm_space)
361361
// Ignore padding field
362362
.finish()
363363
}
@@ -663,7 +663,7 @@ pub const PR_SPEC_FORCE_DISABLE: c_uint = 1 << 3;
663663
pub const PR_SPEC_DISABLE_NOEXEC: c_uint = 1 << 4;
664664
pub const PR_SPEC_STORE_BYPASS: c_int = 0;
665665
pub const PR_SPEC_INDIRECT_BRANCH: c_int = 1;
666-
// FIXME: perharps for later
666+
// FIXME(linux): perharps for later
667667
//pub const PR_SPEC_L1D_FLUSH: c_int = 2;
668668

669669
pub const MCL_CURRENT: c_int = 0x0001;

‎src/unix/linux_like/linux/gnu/mod.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -661,7 +661,7 @@ cfg_if! {
661661
.field("ut_line", &self.ut_line)
662662
.field("ut_id", &self.ut_id)
663663
.field("ut_user", &self.ut_user)
664-
// FIXME: .field("ut_host", &self.ut_host)
664+
// FIXME(debug): .field("ut_host", &self.ut_host)
665665
.field("ut_exit", &self.ut_exit)
666666
.field("ut_session", &self.ut_session)
667667
.field("ut_tv", &self.ut_tv)

‎src/unix/linux_like/linux/mod.rs‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ pub type sctp_assoc_t = __s32;
7676
pub type eventfd_t = u64;
7777
missing! {
7878
#[cfg_attr(feature = "extra_traits", derive(Debug))]
79-
pub enum fpos64_t {} // FIXME: fill this out with a struct
79+
pub enum fpos64_t {} // FIXME(linux): fill this out with a struct
8080
}
8181

8282
e! {
@@ -1751,7 +1751,7 @@ cfg_if! {
17511751
.field("d_off", &self.d_off)
17521752
.field("d_reclen", &self.d_reclen)
17531753
.field("d_type", &self.d_type)
1754-
// FIXME: .field("d_name", &self.d_name)
1754+
// FIXME(debug): .field("d_name", &self.d_name)
17551755
.finish()
17561756
}
17571757
}
@@ -1789,7 +1789,7 @@ cfg_if! {
17891789
.field("d_off", &self.d_off)
17901790
.field("d_reclen", &self.d_reclen)
17911791
.field("d_type", &self.d_type)
1792-
// FIXME: .field("d_name", &self.d_name)
1792+
// FIXME(debug): .field("d_name", &self.d_name)
17931793
.finish()
17941794
}
17951795
}
@@ -1815,7 +1815,7 @@ cfg_if! {
18151815
impl fmt::Debug for pthread_cond_t {
18161816
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
18171817
f.debug_struct("pthread_cond_t")
1818-
// FIXME: .field("size", &self.size)
1818+
// FIXME(debug): .field("size", &self.size)
18191819
.finish()
18201820
}
18211821
}
@@ -1837,7 +1837,7 @@ cfg_if! {
18371837
impl fmt::Debug for pthread_mutex_t {
18381838
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
18391839
f.debug_struct("pthread_mutex_t")
1840-
// FIXME: .field("size", &self.size)
1840+
// FIXME(debug): .field("size", &self.size)
18411841
.finish()
18421842
}
18431843
}
@@ -1859,7 +1859,7 @@ cfg_if! {
18591859
impl fmt::Debug for pthread_rwlock_t {
18601860
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
18611861
f.debug_struct("pthread_rwlock_t")
1862-
// FIXME: .field("size", &self.size)
1862+
// FIXME(debug): .field("size", &self.size)
18631863
.finish()
18641864
}
18651865
}

‎src/unix/linux_like/linux/musl/b32/hexagon.rs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ pub const SIGVTALRM: c_int = 26;
233233
pub const SIGWINCH: c_int = 28;
234234
pub const SIGXCPU: c_int = 24;
235235
pub const SIGXFSZ: c_int = 25;
236-
pub const SIG_SETMASK: c_int = 2; // FIXME check these
236+
pub const SIG_SETMASK: c_int = 2; // FIXME(musl) check these
237237
pub const SIG_BLOCK: c_int = 0x000000;
238238
pub const SIG_UNBLOCK: c_int = 0x01;
239239
pub const SOCK_DGRAM: c_int = 2;
@@ -286,7 +286,7 @@ pub const SYS_clock_settime: c_int = 112;
286286
pub const SYS_clone: c_int = 220;
287287
pub const SYS_close: c_int = 57;
288288
pub const SYS_connect: c_int = 203;
289-
pub const SYS_copy_file_range: c_int = -1; // FIXME
289+
pub const SYS_copy_file_range: c_int = -1; // FIXME(musl)
290290
pub const SYS_creat: c_int = 1064;
291291
pub const SYS_delete_module: c_int = 106;
292292
pub const SYS_dup2: c_int = 1041;

‎src/unix/linux_like/linux/musl/b64/s390x.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ s! {
6363
}
6464

6565
s_no_extra_traits! {
66-
// FIXME: This is actually a union.
66+
// FIXME(union): This is actually a union.
6767
pub struct fpreg_t {
6868
pub d: c_double,
6969
// f: c_float,

‎src/unix/linux_like/linux/musl/b64/x86_64/mod.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ cfg_if! {
205205
.field("mxcsr", &self.mxcsr)
206206
.field("mxcr_mask", &self.mxcr_mask)
207207
.field("st_space", &self.st_space)
208-
// FIXME: .field("xmm_space", &self.xmm_space)
208+
// FIXME(debug): .field("xmm_space", &self.xmm_space)
209209
// Ignore padding field
210210
.finish()
211211
}

‎src/unix/linux_like/linux/musl/mod.rs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -516,7 +516,7 @@ s_no_extra_traits! {
516516
pub __reserved: [c_char; 256],
517517
}
518518

519-
// FIXME: musl added paddings and adjusted
519+
// FIXME(musl): musl added paddings and adjusted
520520
// layout in 1.2.0 but our CI is still 1.1.24.
521521
// So, I'm leaving some fields as cfg for now.
522522
// ref. https://github.com/bminor/musl/commit/
@@ -608,7 +608,7 @@ cfg_if! {
608608
.field("totalhigh", &self.totalhigh)
609609
.field("freehigh", &self.freehigh)
610610
.field("mem_unit", &self.mem_unit)
611-
// FIXME: .field("__reserved", &self.__reserved)
611+
// FIXME(debug): .field("__reserved", &self.__reserved)
612612
.finish()
613613
}
614614
}
@@ -665,7 +665,7 @@ cfg_if! {
665665
.field("ut_line", &self.ut_line)
666666
.field("ut_id", &self.ut_id)
667667
.field("ut_user", &self.ut_user)
668-
//FIXME: .field("ut_host", &self.ut_host)
668+
//FIXME(debug): .field("ut_host", &self.ut_host)
669669
.field("ut_exit", &self.ut_exit)
670670
.field("ut_session", &self.ut_session)
671671
//.field("__ut_pad2", &self.__ut_pad2)

‎src/unix/linux_like/linux/uclibc/arm/mod.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -895,7 +895,7 @@ pub const SYS_pwritev2: c_long = 393;
895895
pub const SYS_pkey_mprotect: c_long = 394;
896896
pub const SYS_pkey_alloc: c_long = 395;
897897
pub const SYS_pkey_free: c_long = 396;
898-
// FIXME: should be a `c_long` too, but a bug slipped in.
898+
// FIXME(linux): should be a `c_long` too, but a bug slipped in.
899899
pub const SYS_statx: c_int = 397;
900900
pub const SYS_pidfd_send_signal: c_long = 424;
901901
pub const SYS_io_uring_setup: c_long = 425;

0 commit comments

Comments
 (0)