Skip to content

Commit 470f583

Browse files
committed
improve diagram per pnkfelix's suggestion
1 parent 0b19bd9 commit 470f583

File tree

1 file changed

+16
-12
lines changed

1 file changed

+16
-12
lines changed

src/how_to/propose.md

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,10 @@ The following lays out the complete flow chart for language features. Note that
1919
```mermaid
2020
flowchart TD
2121
22-
TweakToExistingFeature["Proposing a small addition or\ntweaking an existing feature?"]
23-
24-
NewFeatureOrComplexChange["New feature, or a complex change?"]
25-
22+
subgraph LangTeamChangeProcess [Lang Team Change Process]
23+
TweakToExistingFeature["How large is your proposed change?"]
2624
LangTeamChampion["Are you an experienced contributor\nwith a lang team champion?"]
25+
NeedToExperiment["Do you need to experiment\nbefore you can write RFC?"]
2726
2827
subgraph Stages
2928
ExperimentalFeatureGateProposed["Create a tracking issue and\nopen a rust-lang/rust PR proposing\nan experimental feature gate"]
@@ -51,18 +50,23 @@ subgraph Stages
5150
TypesTeamApproval --> StabilizationAccepted
5251
StabilizationProposed --and this--> StyleTeamNotified
5352
StyleTeamNotified --> StabilizationAccepted
54-
StabilizationAccepted -.if a change is needed.-> ChangeProposed
5553
ChangeProposed --FCP proposed and accepted--> ChangeAccepted
56-
ChangeAccepted -.if more changes are needed.-> ChangeProposed
54+
ChangeProposed -- If team feels change\nmerits a second RFC --> RFCOpen
5755
end
5856
59-
TweakToExistingFeature --> ChangeProposed
60-
61-
NewFeatureOrComplexChange --> RFCOpen
62-
63-
LangTeamChampion -- Yes --> ExperimentalFeatureGateProposed
64-
57+
TweakToExistingFeature -- Tweak to an existing aspect of Rust --> ChangeProposed
58+
TweakToExistingFeature -- New feature or a complex change --> LangTeamChampion
59+
LangTeamChampion -- Yes --> NeedToExperiment
6560
LangTeamChampion -- No --> RFCOpen
61+
NeedToExperiment -- Yes --> ExperimentalFeatureGateProposed
62+
NeedToExperiment -- No --> RFCOpen
63+
end
64+
65+
%% Drawn from https://coolors.co/25283d-8f3985-a675a1-cea2ac-efd9ce
66+
classDef pink fill:#EFD9CE
67+
classDef tuscany fill:#CEA2AC
68+
class LangTeamChangeProcess pink
69+
class Stages tuscany
6670
6771
click RFCOpen href "https://github.com/rust-lang/rfcs/#when-you-need-to-follow-this-process" "Read about RFCs"
6872
click RFCAccepted href "https://forge.rust-lang.org/lang/rfc-merge-procedure.html" "RFC merge procedure"

0 commit comments

Comments
 (0)