Add a test

Author: JohnTitor

highfive/tests/fakes.py

@@ -65,6 +65,16 @@ def get_repo_configs():
                     "reviewers": ["@pnkfelix"],
                 }
             }
+        },
+        'mentions_without_dirs': {
+            "groups": {"all": ["@JohnTitor"]},
+            "dirs": {},
+            "mentions": {
+                "README.md": {
+                    "message": "should be pinged",
+                    "reviewers": ["@JohnTitor"],
+                }
+            }
         }
     }
 

highfive/tests/fakes/mentions-without-dirs.diff

@@ -0,0 +1,12 @@
+diff --git a/README.md b/README.md
+index 5ec94e189f8..b35fbba3fcd 100644
+--- a/README.md
++++ b/README.md
+@@ -1,6 +1,6 @@
+ # The Rust Programming Language
+ 
+-This is the main source code repository for [Rust]. It contains the compiler,
++Hey! This is the main source code repository for [Rust]. It contains the compiler,
+ standard library, and documentation.
+ 
+ [Rust]: https://www.rust-lang.org

highfive/tests/test_newpr.py

@@ -1033,6 +1033,7 @@ def make_fakes(cls):
                 'normal': load_fake('normal.diff'),
                 'travis-yml': load_fake('travis-yml.diff'),
                 'mentions': load_fake('mentions.diff'),
+                'mentions-without-dirs': load_fake('mentions-without-dirs.diff'),
             },
             'config': fakes.get_repo_configs(),
             'global_': fakes.get_global_configs(),
@@ -1206,6 +1207,15 @@ def test_mentions(self):
         # @ehuss should not be listed here
         assert set(["@pnkfelix", "@GuillaumeGomez"]) == mentions
 
+    def test_mentions_without_dirs(self):
+        """Test pinging people even if the dirs key is empty."""
+        self.handler = HighfiveHandlerMock(
+            Payload({}), repo_config=self.fakes['config']['mentions_without_dirs']
+        ).handler
+        (chosen_reviewers, mentions) = self.choose_reviewers(
+            self.fakes['diff']['mentions-without-dirs'], "@JohnTitor",
+        )
+        assert set(["@JohnTitor"]) == mentions
 
 class TestRun(TestNewPR):
     @pytest.fixture(autouse=True)