Merge pull request #210 from GuillaumeGomez/run-rustdoc-ui

Start rustdoc UI tests when a PR is opened with changes on HTML/CSS/JS

Author: pietroalbini

highfive/configs/rust-lang/rust.json

@@ -38,15 +38,25 @@
     },
     "mentions": {
         "src/librustdoc/html/static": {
-            "message": "Some changes occurred in HTML/CSS.",
+            "message": "Some changes occurred in HTML/CSS/JS.",
+            "command": "@highfive: run-doc-ui",
+            "reviewers": ["@GuillaumeGomez"]
+        },
+        "src/librustdoc/html/static/themes": {
+            "message": "Some changes occurred in HTML/CSS themes.",
+            "command": "@highfive: run-doc-ui",
             "reviewers": ["@GuillaumeGomez"]
         },
-        "src/src/doc": {
+        "src/doc": {
             "message": "Some changes occurred in HTML/CSS.",
             "reviewers": ["@GuillaumeGomez"]
         },
+        "src/librustdoc/": {
+            "command": "@highfive: run-doc-ui"
+        },
         "error_codes.rs": {
             "message": "Some changes occurred in diagnostic error codes",
+            "command": "@highfive: run-doc-ui",
             "reviewers": ["@GuillaumeGomez"]
         }
     },

highfive/newpr.py

@@ -124,13 +124,21 @@ def set_assignee(self, assignee, owner, repo, issue, user, author, to_mention):
                 client.send_then_quit("{}: ping to review issue https://www.github.com/{}/{}/pull/{} by {}."
                     .format(irc_name_of_reviewer, owner, repo, issue, author))
 
+        commands = {}
         if to_mention and len(to_mention) > 0:
             message = ''
             for mention in to_mention:
                 if len(message) > 0:
                     message += '\n\n'
                 message += "%s\n\ncc %s" % (mention['message'],
                                             ','.join([x for x in mention['reviewers'] if x != user]))
+                cmd = mention.get('command')
+                if cmd is not None:
+                    commands[cmd] = self.payload['pull_request', 'head', 'sha']
+            for cmd in commands:
+                if len(message) > 0:
+                    message += '\n\n'
+                message += "%s %s" % (cmd, commands[cmd])
             self.post_comment(message, owner, repo, issue)
 
     def get_irc_nick(self, gh_name):