Fix clippy issues

Author: Amanieu

ci/tools.sh

@@ -35,7 +35,7 @@ fi
 
 if [ "${TRAVIS_OS_NAME}" = "linux" ]; then
     if retry rustup component add clippy ; then
-        cargo clippy --all --target=i586-unknown-linux-gnu -- -D clippy::pedantic
+        cargo clippy --all --target=i586-unknown-linux-gnu -- -D clippy::all -D clippy::pedantic
     fi
 fi
 

src/map.rs

@@ -181,14 +181,12 @@ pub enum DefaultHashBuilder {}
 /// ```
 /// use hashbrown::HashMap;
 ///
-/// fn main() {
-///     let timber_resources: HashMap<&str, i32> =
-///     [("Norway", 100),
-///      ("Denmark", 50),
-///      ("Iceland", 10)]
-///      .iter().cloned().collect();
-///     // use the values stored in map
-/// }
+/// let timber_resources: HashMap<&str, i32> =
+/// [("Norway", 100),
+///  ("Denmark", 50),
+///  ("Iceland", 10)]
+///  .iter().cloned().collect();
+/// // use the values stored in map
 /// ```
 #[derive(Clone)]
 pub struct HashMap<K, V, S = DefaultHashBuilder> {
@@ -903,12 +901,10 @@ where
     /// ```
     /// use hashbrown::HashMap;
     ///
-    /// # fn main() {
     /// let mut map = HashMap::new();
     /// map.insert(1, "a");
     /// assert_eq!(map.remove_entry(&1), Some((1, "a")));
     /// assert_eq!(map.remove(&1), None);
-    /// # }
     /// ```
     #[cfg_attr(feature = "inline-more", inline)]
     pub fn remove_entry<Q: ?Sized>(&mut self, k: &Q) -> Option<(K, V)>
@@ -2283,14 +2279,12 @@ impl<'a, K, V: Default, S> Entry<'a, K, V, S> {
     /// # Examples
     ///
     /// ```
-    /// # fn main() {
     /// use hashbrown::HashMap;
     ///
     /// let mut map: HashMap<&str, Option<u32>> = HashMap::new();
     /// map.entry("poneyland").or_default();
     ///
     /// assert_eq!(map["poneyland"], None);
-    /// # }
     /// ```
     #[cfg_attr(feature = "inline-more", inline)]
     pub fn or_default(self) -> &'a mut V

src/raw/generic.rs

@@ -132,7 +132,7 @@ impl Group {
 
     /// Returns a `BitMask` indicating all bytes in the group which are full.
     #[inline]
-    pub fn match_full(&self) -> BitMask {
+    pub fn match_full(self) -> BitMask {
         self.match_empty_or_deleted().invert()
     }
 

src/raw/mod.rs

@@ -74,20 +74,18 @@ impl Fallibility {
     /// Error to return on capacity overflow.
     #[cfg_attr(feature = "inline-more", inline)]
     fn capacity_overflow(self) -> CollectionAllocErr {
-        use Fallibility::*;
         match self {
-            Fallible => CollectionAllocErr::CapacityOverflow,
-            Infallible => panic!("Hash table capacity overflow"),
+            Fallibility::Fallible => CollectionAllocErr::CapacityOverflow,
+            Fallibility::Infallible => panic!("Hash table capacity overflow"),
         }
     }
 
     /// Error to return on allocation error.
     #[cfg_attr(feature = "inline-more", inline)]
     fn alloc_err(self, layout: Layout) -> CollectionAllocErr {
-        use Fallibility::*;
         match self {
-            Fallible => CollectionAllocErr::AllocErr { layout },
-            Infallible => handle_alloc_error(layout),
+            Fallibility::Fallible => CollectionAllocErr::AllocErr { layout },
+            Fallibility::Infallible => handle_alloc_error(layout),
         }
     }
 }