Change Forward to drop sink after completion

Author: ebkalderon

futures-util/src/stream/forward.rs

@@ -71,7 +71,7 @@ where
     Si: Sink + Unpin,
     St: Stream<Item = Result<Si::SinkItem, Si::SinkError>>,
 {
-    type Output = Result<Si, Si::SinkError>;
+    type Output = Result<(), Si::SinkError>;
 
     fn poll(
         mut self: Pin<&mut Self>,
@@ -91,7 +91,8 @@ where
                 Poll::Ready(None) => {
                     try_ready!(self.as_mut().sink().as_pin_mut().expect(INVALID_POLL)
                                    .poll_close(waker));
-                    return Poll::Ready(Ok(self.as_mut().sink().take().unwrap()))
+                    let _ = self.as_mut().sink().take().unwrap();
+                    return Poll::Ready(Ok(()))
                 }
                 Poll::Pending => {
                     try_ready!(self.as_mut().sink().as_pin_mut().expect(INVALID_POLL)

futures-util/src/stream/mod.rs

@@ -976,12 +976,6 @@ pub trait StreamExt: Stream {
     /// exhausted, sending each item to the sink. It will complete once both the
     /// stream is exhausted and the sink has received and flushed all items.
     /// Note that the sink is **not** closed.
-    ///
-    /// On completion, the sink is returned.
-    ///
-    /// Note that this combinator is only usable with `Unpin` sinks.
-    /// Sinks that are not `Unpin` will need to be pinned in order to be used
-    /// with `forward`.
     fn forward<S>(self, sink: S) -> Forward<Self, S>
     where
         S: Sink + Unpin,