Start the webserver before trying to download the crates-build-env image

Author: jyn514

src/bin/cratesfyi.rs

@@ -116,7 +116,8 @@ impl CommandLine {
                 socket_addr,
                 reload_templates,
             } => {
-                Server::start(Some(&socket_addr), reload_templates, &ctx)?;
+                // Blocks indefinitely
+                let _ = Server::start(Some(&socket_addr), reload_templates, &ctx)?;
             }
             Self::Daemon {
                 foreground,

src/utils/daemon.rs

@@ -51,6 +51,11 @@ fn start_registry_watcher(context: &dyn Context) -> Result<(), Error> {
 }
 
 pub fn start_daemon(context: &dyn Context, enable_registry_watcher: bool) -> Result<(), Error> {
+    // Start the web server before doing anything more expensive
+    // Please check with an administrator before changing this (see #1172 for context).
+    info!("Starting web server");
+    let _server = crate::Server::start(None, false, context)?;
+
     let config = context.config()?;
 
     if enable_registry_watcher {
@@ -98,10 +103,7 @@ pub fn start_daemon(context: &dyn Context, enable_registry_watcher: bool) -> Res
         },
     )?;
 
-    // at least start web server
-    info!("Starting web server");
-
-    crate::Server::start(None, false, context)?;
+    // Never returns; `server` blocks indefinitely when dropped
     Ok(())
 }
 

src/web/mod.rs

@@ -401,6 +401,7 @@ fn render_markdown(text: &str) -> String {
     markdown_to_html(text, &options)
 }
 
+#[must_use = "`Server` blocks indefinitely when dropped"]
 pub struct Server {
     inner: Listening,
 }