Skip to content

Commit c0a977f

Browse files
Use let binding in LimitedCrateDetails::encode to ensure a field is never forgotten
1 parent 92af2ad commit c0a977f

File tree

1 file changed

+19
-8
lines changed

1 file changed

+19
-8
lines changed

src/web/rustdoc.rs

Lines changed: 19 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -423,14 +423,25 @@ impl bincode::Encode for LimitedCrateDetails {
423423
&self,
424424
encoder: &mut E,
425425
) -> Result<(), bincode::error::EncodeError> {
426-
self.parsed_license.encode(encoder)?;
427-
self.homepage_url.encode(encoder)?;
428-
self.documentation_url.encode(encoder)?;
429-
self.repository_url.encode(encoder)?;
430-
self.owners.encode(encoder)?;
431-
self.dependencies.encode(encoder)?;
432-
self.total_items.encode(encoder)?;
433-
self.documented_items.encode(encoder)?;
426+
let LimitedCrateDetails {
427+
parsed_license,
428+
homepage_url,
429+
documentation_url,
430+
repository_url,
431+
owners,
432+
dependencies,
433+
total_items,
434+
documented_items,
435+
} = self;
436+
437+
parsed_license.encode(encoder)?;
438+
homepage_url.encode(encoder)?;
439+
documentation_url.encode(encoder)?;
440+
repository_url.encode(encoder)?;
441+
owners.encode(encoder)?;
442+
dependencies.encode(encoder)?;
443+
total_items.encode(encoder)?;
444+
documented_items.encode(encoder)?;
434445
Ok(())
435446
}
436447
}

0 commit comments

Comments
 (0)