Merge pull request #1457 from GuillaumeGomez/clippy-warnings

Fix clippy warnings

Author: GuillaumeGomez

src/db/pool.rs

@@ -61,7 +61,7 @@ impl Pool {
     ) -> R {
         #[cfg(test)]
         {
-            f(&self.pool.lock().unwrap().as_ref().unwrap())
+            f(self.pool.lock().unwrap().as_ref().unwrap())
         }
         #[cfg(not(test))]
         {

src/test/mod.rs

@@ -290,7 +290,7 @@ impl TestDatabase {
         // test to create a fresh instance of the database to run within.
         let schema = format!("docs_rs_test_schema_{}", rand::random::<u64>());
 
-        let pool = Pool::new_with_schema(&config, metrics, &schema)?;
+        let pool = Pool::new_with_schema(config, metrics, &schema)?;
         let repository_stats_updater = RepositoryStatsUpdater::new(config, pool.clone());
 
         let mut conn = Connection::connect(&config.database_url, postgres::NoTls)?;

src/web/crate_details.rs

@@ -323,7 +323,7 @@ mod tests {
             &mut db.conn(),
             package,
             version,
-            &db.repository_stats_updater(),
+            db.repository_stats_updater(),
         )
         .ok_or_else(|| failure::err_msg("could not fetch crate details"))?;
 
@@ -358,11 +358,11 @@ mod tests {
                 .yanked(true)
                 .create()?;
 
-            assert_last_successful_build_equals(&db, "foo", "0.0.1", None)?;
-            assert_last_successful_build_equals(&db, "foo", "0.0.2", None)?;
-            assert_last_successful_build_equals(&db, "foo", "0.0.3", Some("0.0.2"))?;
-            assert_last_successful_build_equals(&db, "foo", "0.0.4", None)?;
-            assert_last_successful_build_equals(&db, "foo", "0.0.5", Some("0.0.2"))?;
+            assert_last_successful_build_equals(db, "foo", "0.0.1", None)?;
+            assert_last_successful_build_equals(db, "foo", "0.0.2", None)?;
+            assert_last_successful_build_equals(db, "foo", "0.0.3", Some("0.0.2"))?;
+            assert_last_successful_build_equals(db, "foo", "0.0.4", None)?;
+            assert_last_successful_build_equals(db, "foo", "0.0.5", Some("0.0.2"))?;
             Ok(())
         });
     }
@@ -388,9 +388,9 @@ mod tests {
                 .yanked(true)
                 .create()?;
 
-            assert_last_successful_build_equals(&db, "foo", "0.0.1", None)?;
-            assert_last_successful_build_equals(&db, "foo", "0.0.2", None)?;
-            assert_last_successful_build_equals(&db, "foo", "0.0.3", None)?;
+            assert_last_successful_build_equals(db, "foo", "0.0.1", None)?;
+            assert_last_successful_build_equals(db, "foo", "0.0.2", None)?;
+            assert_last_successful_build_equals(db, "foo", "0.0.3", None)?;
             Ok(())
         });
     }
@@ -413,10 +413,10 @@ mod tests {
                 .create()?;
             env.fake_release().name("foo").version("0.0.4").create()?;
 
-            assert_last_successful_build_equals(&db, "foo", "0.0.1", None)?;
-            assert_last_successful_build_equals(&db, "foo", "0.0.2", Some("0.0.4"))?;
-            assert_last_successful_build_equals(&db, "foo", "0.0.3", None)?;
-            assert_last_successful_build_equals(&db, "foo", "0.0.4", None)?;
+            assert_last_successful_build_equals(db, "foo", "0.0.1", None)?;
+            assert_last_successful_build_equals(db, "foo", "0.0.2", Some("0.0.4"))?;
+            assert_last_successful_build_equals(db, "foo", "0.0.3", None)?;
+            assert_last_successful_build_equals(db, "foo", "0.0.4", None)?;
             Ok(())
         });
     }
@@ -456,7 +456,7 @@ mod tests {
                 &mut db.conn(),
                 "foo",
                 "0.2.0",
-                &db.repository_stats_updater(),
+                db.repository_stats_updater(),
             )
             .unwrap();
             assert_eq!(
@@ -531,7 +531,7 @@ mod tests {
                     &mut db.conn(),
                     "foo",
                     version,
-                    &db.repository_stats_updater(),
+                    db.repository_stats_updater(),
                 )
                 .unwrap();
                 assert_eq!(
@@ -561,7 +561,7 @@ mod tests {
                     &mut db.conn(),
                     "foo",
                     version,
-                    &db.repository_stats_updater(),
+                    db.repository_stats_updater(),
                 )
                 .unwrap();
                 assert_eq!(
@@ -592,7 +592,7 @@ mod tests {
                     &mut db.conn(),
                     "foo",
                     version,
-                    &db.repository_stats_updater(),
+                    db.repository_stats_updater(),
                 )
                 .unwrap();
                 assert_eq!(
@@ -631,7 +631,7 @@ mod tests {
                     &mut db.conn(),
                     "foo",
                     version,
-                    &db.repository_stats_updater(),
+                    db.repository_stats_updater(),
                 )
                 .unwrap();
                 assert_eq!(
@@ -693,7 +693,7 @@ mod tests {
                 &mut db.conn(),
                 "foo",
                 "0.0.1",
-                &db.repository_stats_updater(),
+                db.repository_stats_updater(),
             )
             .unwrap();
             assert_eq!(
@@ -723,7 +723,7 @@ mod tests {
                 &mut db.conn(),
                 "foo",
                 "0.0.1",
-                &db.repository_stats_updater(),
+                db.repository_stats_updater(),
             )
             .unwrap();
             let mut owners = details.owners;
@@ -752,7 +752,7 @@ mod tests {
                 &mut db.conn(),
                 "foo",
                 "0.0.1",
-                &db.repository_stats_updater(),
+                db.repository_stats_updater(),
             )
             .unwrap();
             assert_eq!(
@@ -776,7 +776,7 @@ mod tests {
                 &mut db.conn(),
                 "foo",
                 "0.0.1",
-                &db.repository_stats_updater(),
+                db.repository_stats_updater(),
             )
             .unwrap();
             assert_eq!(

src/web/rustdoc.rs

@@ -831,27 +831,27 @@ mod test {
             let web = env.frontend();
 
             // check it works at all
-            let redirect = latest_version_redirect("/dummy/0.1.0/dummy/", &web)?;
+            let redirect = latest_version_redirect("/dummy/0.1.0/dummy/", web)?;
             assert_eq!(
                 redirect,
                 "/crate/dummy/0.2.0/target-redirect/x86_64-unknown-linux-gnu/dummy/index.html"
             );
 
             // check it keeps the subpage
-            let redirect = latest_version_redirect("/dummy/0.1.0/dummy/blah/", &web)?;
+            let redirect = latest_version_redirect("/dummy/0.1.0/dummy/blah/", web)?;
             assert_eq!(
                 redirect,
                 "/crate/dummy/0.2.0/target-redirect/x86_64-unknown-linux-gnu/dummy/blah/index.html"
             );
-            let redirect = latest_version_redirect("/dummy/0.1.0/dummy/blah/blah.html", &web)?;
+            let redirect = latest_version_redirect("/dummy/0.1.0/dummy/blah/blah.html", web)?;
             assert_eq!(
                 redirect,
                 "/crate/dummy/0.2.0/target-redirect/x86_64-unknown-linux-gnu/dummy/blah/blah.html"
             );
 
             // check it also works for deleted pages
             let redirect =
-                latest_version_redirect("/dummy/0.1.0/dummy/struct.will-be-deleted.html", &web)?;
+                latest_version_redirect("/dummy/0.1.0/dummy/struct.will-be-deleted.html", web)?;
             assert_eq!(redirect, "/crate/dummy/0.2.0/target-redirect/x86_64-unknown-linux-gnu/dummy/struct.will-be-deleted.html");
 
             Ok(())
@@ -891,7 +891,7 @@ mod test {
 
             let redirect = latest_version_redirect(
                 "/dummy/0.1.0/x86_64-pc-windows-msvc/dummy/struct.Blah.html",
-                &web,
+                web,
             )?;
             assert_eq!(
                 redirect,
@@ -1049,7 +1049,7 @@ mod test {
             assert_redirect(
                 "/zstd/badge.svg",
                 "/zstd/badge.svg?version=0.5.1%2Bzstd.1.4.4",
-                &frontend,
+                frontend,
             )?;
             Ok(())
         })