models/krate: Extract NewCrate::create() fn

When using `create_or_update()` in the test suite we usually only really want `create()` without any unintentional updates.

Author: Turbo87

src/downloads_counter.rs

@@ -439,7 +439,7 @@ mod tests {
                 name: "foo",
                 ..NewCrate::default()
             }
-            .create_or_update(conn, user.id)
+            .create(conn, user.id)
             .expect("failed to create crate");
 
             Self {

src/models/krate.rs

@@ -120,33 +120,35 @@ impl<'a> NewCrate<'a> {
         })
     }
 
-    fn save_new_crate(&self, conn: &mut PgConnection, user_id: i32) -> QueryResult<Option<Crate>> {
+    pub fn create(&self, conn: &mut PgConnection, user_id: i32) -> QueryResult<Crate> {
         use crate::schema::crates::dsl::*;
 
         conn.transaction(|conn| {
-            let maybe_inserted: Option<Crate> = diesel::insert_into(crates)
+            let krate: Crate = diesel::insert_into(crates)
                 .values(self)
                 .on_conflict_do_nothing()
                 .returning(Crate::as_returning())
-                .get_result(conn)
-                .optional()?;
-
-            if let Some(ref krate) = maybe_inserted {
-                let owner = CrateOwner {
-                    crate_id: krate.id,
-                    owner_id: user_id,
-                    created_by: user_id,
-                    owner_kind: OwnerKind::User as i32,
-                    email_notifications: true,
-                };
-                diesel::insert_into(crate_owners::table)
-                    .values(&owner)
-                    .execute(conn)?;
-            }
+                .get_result(conn)?;
 
-            Ok(maybe_inserted)
+            let owner = CrateOwner {
+                crate_id: krate.id,
+                owner_id: user_id,
+                created_by: user_id,
+                owner_kind: OwnerKind::User as i32,
+                email_notifications: true,
+            };
+
+            diesel::insert_into(crate_owners::table)
+                .values(&owner)
+                .execute(conn)?;
+
+            Ok(krate)
         })
     }
+
+    fn save_new_crate(&self, conn: &mut PgConnection, user_id: i32) -> QueryResult<Option<Crate>> {
+        conn.transaction(|conn| self.create(conn, user_id).optional())
+    }
 }
 
 impl Crate {

src/tests/builders/krate.rs

@@ -114,7 +114,7 @@ impl<'a> CrateBuilder<'a> {
     pub fn build(mut self, connection: &mut PgConnection) -> AppResult<Crate> {
         use diesel::{insert_into, select, update};
 
-        let mut krate = self.krate.create_or_update(connection, self.owner_id)?;
+        let mut krate = self.krate.create(connection, self.owner_id)?;
 
         // Since we are using `NewCrate`, we can't set all the
         // crate properties in a single DB call.

src/worker/update_downloads.rs

@@ -98,7 +98,7 @@ mod test {
             name: "foo",
             ..Default::default()
         }
-        .create_or_update(conn, user_id)
+        .create(conn, user_id)
         .unwrap();
         let version = NewVersion::new(
             krate.id,