Skip to content

Commit cd1d40a

Browse files
committed
models/krate: Use assert_ok/err!() assertion macros
Compared to the output of `assert!()` (`true != false`), these give a bit more context on the actual and expected values.
1 parent d05d209 commit cd1d40a

File tree

1 file changed

+23
-22
lines changed

1 file changed

+23
-22
lines changed

src/models/krate.rs

Lines changed: 23 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -559,29 +559,30 @@ mod tests {
559559
assert!(Crate::valid_dependency_name("_foo"));
560560
assert!(!Crate::valid_dependency_name("-foo"));
561561
}
562+
562563
#[test]
563564
fn valid_feature_names() {
564-
assert!(Crate::valid_feature("foo").is_ok());
565-
assert!(Crate::valid_feature("1foo").is_ok());
566-
assert!(Crate::valid_feature("_foo").is_ok());
567-
assert!(Crate::valid_feature("_foo-_+.1").is_ok());
568-
assert!(Crate::valid_feature("_foo-_+.1").is_ok());
569-
assert!(Crate::valid_feature("").is_err());
570-
assert!(Crate::valid_feature("/").is_err());
571-
assert!(Crate::valid_feature("%/%").is_err());
572-
assert!(Crate::valid_feature("a/a").is_ok());
573-
assert!(Crate::valid_feature("32-column-tables").is_ok());
574-
assert!(Crate::valid_feature("c++20").is_ok());
575-
assert!(Crate::valid_feature("krate/c++20").is_ok());
576-
assert!(Crate::valid_feature("c++20/wow").is_err());
577-
assert!(Crate::valid_feature("foo?/bar").is_ok());
578-
assert!(Crate::valid_feature("dep:foo").is_ok());
579-
assert!(Crate::valid_feature("dep:foo?/bar").is_err());
580-
assert!(Crate::valid_feature("foo/?bar").is_err());
581-
assert!(Crate::valid_feature("foo?bar").is_err());
582-
assert!(Crate::valid_feature("bar.web").is_ok());
583-
assert!(Crate::valid_feature("foo/bar.web").is_ok());
584-
assert!(Crate::valid_feature("dep:0foo").is_err());
585-
assert!(Crate::valid_feature("0foo?/bar.web").is_err());
565+
assert_ok!(Crate::valid_feature("foo"));
566+
assert_ok!(Crate::valid_feature("1foo"));
567+
assert_ok!(Crate::valid_feature("_foo"));
568+
assert_ok!(Crate::valid_feature("_foo-_+.1"));
569+
assert_ok!(Crate::valid_feature("_foo-_+.1"));
570+
assert_err!(Crate::valid_feature(""));
571+
assert_err!(Crate::valid_feature("/"));
572+
assert_err!(Crate::valid_feature("%/%"));
573+
assert_ok!(Crate::valid_feature("a/a"));
574+
assert_ok!(Crate::valid_feature("32-column-tables"));
575+
assert_ok!(Crate::valid_feature("c++20"));
576+
assert_ok!(Crate::valid_feature("krate/c++20"));
577+
assert_err!(Crate::valid_feature("c++20/wow"));
578+
assert_ok!(Crate::valid_feature("foo?/bar"));
579+
assert_ok!(Crate::valid_feature("dep:foo"));
580+
assert_err!(Crate::valid_feature("dep:foo?/bar"));
581+
assert_err!(Crate::valid_feature("foo/?bar"));
582+
assert_err!(Crate::valid_feature("foo?bar"));
583+
assert_ok!(Crate::valid_feature("bar.web"));
584+
assert_ok!(Crate::valid_feature("foo/bar.web"));
585+
assert_err!(Crate::valid_feature("dep:0foo"));
586+
assert_err!(Crate::valid_feature("0foo?/bar.web"));
586587
}
587588
}

0 commit comments

Comments
 (0)