mark experiment as failed when an error is encountered

zeegomo · zeegomo · commit a69c3f5fe39b · 2019-01-23T13:15:19.000+01:00
diff --git a/src/experiments.rs b/src/experiments.rs
@@ -227,7 +227,10 @@ impl Experiment {
             )?;
             self.started_at = Some(now);
         // Check if the old status was "running" and there is no completed date
-        } else if self.status == Status::Running && self.completed_at.is_none() {
+        } else if self.status == Status::Running
+            && self.completed_at.is_none()
+            && status != Status::Failed
+        {
             db.execute(
                 "UPDATE experiments SET completed_at = ?1 WHERE name = ?2;",
                 &[&now, &self.name.as_str()],
diff --git a/src/server/routes/agent.rs b/src/server/routes/agent.rs
@@ -162,21 +162,28 @@ fn endpoint_error(
     data: Arc<Data>,
     auth: AuthDetails,
 ) -> Fallible<Response<Body>> {
-    let ex = Experiment::run_by(&data.db, &Assignee::Agent(auth.name.clone()))?
+    let mut ex = Experiment::run_by(&data.db, &Assignee::Agent(auth.name.clone()))?
         .ok_or_else(|| err_msg("no experiment run by this agent"))?;
 
+    ex.set_status(&data.db, Status::Failed)?;
+
     if let Some(ref github_issue) = ex.github_issue {
         Message::new()
             .line(
-                "exclamation",
+                "rotating_light",
                 format!(
-                    "Experiment **`{}`** running on agent `{}` has encountered an error",
-                    ex.name, auth.name,
+                    "Experiment **`{}`** has encountered an error: {}",
+                    ex.name,
+                    error.get("error").unwrap_or(&String::from("no error")),
                 ),
             )
             .line(
+                "hammer_and_wrench",
+                "If the error is fixed use the `retry` command.",
+            )
+            .note(
                 "sos",
-                format!("caused by: {}", error.get("error").unwrap(),),
+                "Can someone from the infra team check in on this? @rust-lang/infra",
             )
             .send(&github_issue.api_url, &data)?;
     }
