Percent encode toolchain string when used in a path

Author: ecstatic-morse

src/dirs.rs

@@ -43,6 +43,6 @@ pub(crate) fn crate_source_dir(ex: &Experiment, tc: &Toolchain, krate: &Crate) -
     EXPERIMENT_DIR
         .join(&ex.name)
         .join("sources")
-        .join(tc.to_string())
+        .join(tc.to_path_component())
         .join(krate.id())
 }

src/toolchain.rs

@@ -101,7 +101,7 @@ impl Toolchain {
             dir = dir.join("shared");
         }
 
-        dir.join(self.to_string())
+        dir.join(self.to_path_component())
     }
 
     pub fn prep_offline_registry(&self) -> Fallible<()> {
@@ -121,6 +121,12 @@ impl Toolchain {
         // is ready
         Ok(())
     }
+
+    pub fn to_path_component(&self) -> String {
+        use url::percent_encoding::utf8_percent_encode as encode;
+
+        encode(&self.to_string(), utils::fs::FILENAME_ENCODE_SET).to_string()
+    }
 }
 
 impl fmt::Display for Toolchain {

src/utils/fs.rs

@@ -2,8 +2,16 @@ use crate::prelude::*;
 use crate::utils::try_hard_limit;
 use std::fs;
 use std::path::{Path, PathBuf};
+use url::percent_encoding::SIMPLE_ENCODE_SET;
 use walkdir::{DirEntry, WalkDir};
 
+url::define_encode_set! {
+    /// The set of characters which cannot be used in a [filename on Windows][windows].
+    ///
+    /// [windows]: https://docs.microsoft.com/en-us/windows/desktop/fileio/naming-a-file#naming-conventions
+    pub FILENAME_ENCODE_SET = [SIMPLE_ENCODE_SET] | { '<', '>', ':', '"', '/', '\\', '|', '?', '*' }
+}
+
 pub(crate) fn try_canonicalize<P: AsRef<Path>>(path: P) -> PathBuf {
     fs::canonicalize(&path).unwrap_or_else(|_| path.as_ref().to_path_buf())
 }