Fix clippy lints

Author: Mark-Simulacrum

src/agent/api.rs

@@ -112,8 +112,7 @@ impl AgentApi {
                             rand::thread_rng().gen_range(500..(retry_interval * 1000)),
                         );
                         warn!(
-                            "connection to the server failed. retrying in {:?}...",
-                            sleep_for
+                            "connection to the server failed. retrying in {sleep_for:?}..."
                         );
                         ::std::thread::sleep(sleep_for);
                         retry_interval *= 2;

src/agent/mod.rs

@@ -73,7 +73,7 @@ pub struct Agent {
 
 impl Agent {
     fn new(url: &str, token: &str, caps: &Capabilities) -> Fallible<Self> {
-        info!("connecting to crater server {}...", url);
+        info!("connecting to crater server {url}...");
 
         let api = AgentApi::new(url, token);
         let config = api.config(caps)?;
@@ -166,7 +166,7 @@ fn run_experiment(
             }
         }
         Err(err) => {
-            warn!("failed to check the disk usage: {}", err);
+            warn!("failed to check the disk usage: {err}");
         }
     }
 

src/cli.rs

@@ -33,8 +33,6 @@ use std::time::Duration;
 #[derive(Debug, Clone)]
 pub struct Ex(String);
 
-#[derive(Debug, Clone)]
-pub struct DockerEnv(#[allow(unused)] String);
 impl FromStr for Ex {
     type Err = Error;
 
@@ -43,14 +41,6 @@ impl FromStr for Ex {
     }
 }
 
-impl FromStr for DockerEnv {
-    type Err = Error;
-
-    fn from_str(env: &str) -> Result<DockerEnv> {
-        Ok(DockerEnv(env.to_string()))
-    }
-}
-
 #[derive(Debug, Clone)]
 pub struct Dest(PathBuf);
 

src/config.rs

@@ -158,7 +158,7 @@ impl Config {
 
     fn check_for_dup_keys(buffer: &str) -> Fallible<()> {
         if let Err(e) = ::toml::from_str::<::toml::Value>(buffer) {
-            error!("got error parsing the config-file: {}", e);
+            error!("got error parsing the config-file: {e}");
             Err(e.into())
         } else {
             Ok(())
@@ -184,8 +184,7 @@ impl Config {
         for crate_name in self.crates.keys() {
             if !list_of_crates.contains(crate_name) {
                 error!(
-                    "check-config failed: crate `{}` is not available.",
-                    crate_name
+                    "check-config failed: crate `{crate_name}` is not available."
                 );
                 any_missing = true;
             }
@@ -216,8 +215,7 @@ impl Config {
         for repo_name in self.github_repos.keys() {
             if !list_of_crates.contains(repo_name) {
                 error!(
-                    "check-config failed: GitHub repo `{}` is missing",
-                    repo_name
+                    "check-config failed: GitHub repo `{repo_name}` is missing"
                 );
                 any_missing = true;
             }

src/db/migrations.rs

@@ -396,7 +396,7 @@ pub fn execute(db: &mut Connection) -> Fallible<()> {
             t.execute("INSERT INTO migrations (name) VALUES (?1)", [&name])?;
             t.commit()?;
 
-            info!("executed migration: {}", name);
+            info!("executed migration: {name}");
         }
     }
 

src/db/mod.rs

@@ -58,7 +58,7 @@ impl<E: std::error::Error> r2d2::HandleError<E> for ErrorHandler {
     fn handle_error(&self, error: E) {
         // ensure that a message gets logged regardless of whether it's enabled.
         if log::log_enabled!(log::Level::Error) {
-            log::error!("r2d2 error: {:?}", error);
+            log::error!("r2d2 error: {error:?}");
         } else {
             eprintln!("r2d2 error: {error:?}");
         }
@@ -297,9 +297,9 @@ pub trait QueryUtils {
         let elapsed = start.elapsed();
         // Log all queries that take at least 1/2 a second to execute.
         if elapsed.as_millis() > 500 {
-            debug!("sql query \"{}\" executed in {:?}", sql, elapsed);
+            debug!("sql query \"{sql}\" executed in {elapsed:?}");
         } else {
-            trace!("sql query \"{}\" executed in {:?}", sql, elapsed);
+            trace!("sql query \"{sql}\" executed in {elapsed:?}");
         }
         res
     }

src/report/html.rs

@@ -255,7 +255,7 @@ fn write_report<W: ReportWriter>(
         result_names,
     };
 
-    info!("generating {}", to);
+    info!("generating {to}");
 
     if output_templates {
         dest.write_string(

src/report/markdown.rs

@@ -185,7 +185,7 @@ fn write_report<W: ReportWriter>(
     };
 
     let markdown = render_markdown(&context)?;
-    info!("generating {}", to);
+    info!("generating {to}");
     dest.write_string(to, markdown.into(), &mime::TEXT_PLAIN)?;
 
     if output_templates {

src/report/mod.rs

@@ -301,7 +301,7 @@ fn write_logs<DB: ReadResults, W: ReportWriter>(
 
         for (i, krate) in crates.iter().enumerate() {
             if i % progress_every == 0 {
-                info!("wrote logs for {}/{} crates", i, num_crates)
+                info!("wrote logs for {i}/{num_crates} crates")
             }
 
             if config.should_skip(krate) {
@@ -360,7 +360,7 @@ pub fn gen<DB: ReadResults, W: ReportWriter + Display>(
 ) -> Fallible<TestResults> {
     let raw = generate_report(db, config, ex, crates)?;
 
-    info!("writing results to {}", dest);
+    info!("writing results to {dest}");
     info!("writing metadata");
     dest.write_string(
         "results.json",

src/runner/mod.rs

@@ -48,8 +48,7 @@ pub fn run_ex(
     let mut i = 0;
     while !rustwide::cmd::docker_running(workspace) {
         log::error!(
-            "docker is not currently up, waiting for it to start (tried {} times)",
-            i
+            "docker is not currently up, waiting for it to start (tried {i} times)"
         );
         i += 1;
     }
@@ -80,7 +79,7 @@ pub fn run_ex(
         }
     }
 
-    info!("running tasks in {} threads...", threads_count);
+    info!("running tasks in {threads_count} threads...");
 
     let workers = (0..threads_count)
         .map(|i| {