applease clippy

Author: pietroalbini

src/cli.rs

@@ -600,7 +600,10 @@ impl Crater {
             }
             Crater::Server { bind } => {
                 let config = Config::load()?;
-                server::run(config, bind.unwrap_or(([127, 0, 0, 1], 8000).into()))?;
+                server::run(
+                    config,
+                    bind.unwrap_or_else(|| ([127, 0, 0, 1], 8000).into()),
+                )?;
             }
             Crater::Agent {
                 ref url,

src/config.rs

@@ -242,6 +242,7 @@ impl Config {
 }
 
 #[cfg(test)]
+#[allow(clippy::trivial_regex)]
 impl Default for Config {
     fn default() -> Self {
         Config {

src/report/s3.rs

@@ -76,7 +76,7 @@ pub fn get_client_for_bucket(bucket: &str) -> Fallible<Box<dyn S3>> {
         .sync()
         .context(S3Error::UnknownBucketRegion)?;
     let region = match response.location_constraint.as_ref() {
-        Some(region) if region == "" => Region::UsEast1,
+        Some(region) if region.is_empty() => Region::UsEast1,
         Some(region) => Region::from_str(region).context(S3Error::UnknownBucketRegion)?,
         None => return Err(S3Error::UnknownBucketRegion.into()),
     };

src/server/routes/webhooks/mod.rs

@@ -83,7 +83,7 @@ fn process_command(
         }
 
         let command = line[line.find(' ').unwrap()..].trim();
-        if command == "" {
+        if command.is_empty() {
             continue;
         }