Auto merge of #380 - pietroalbini:index-sql, r=pietroalbini

bors · bors · commit 1754343b647b · 2018-12-20T11:02:02.000Z
Reduce the number of SQL queries done in the index

This should hopefully make that page way faster to load.
diff --git a/src/experiments.rs b/src/experiments.rs
@@ -128,10 +128,10 @@ impl Experiment {
         Ok(db.exists("SELECT rowid FROM experiments WHERE name = ?1;", &[&name])?)
     }
 
-    pub fn all(db: &Database) -> Fallible<Vec<Experiment>> {
+    pub fn unfinished(db: &Database) -> Fallible<Vec<Experiment>> {
         let records = db.query(
-            "SELECT * FROM experiments ORDER BY priority DESC, created_at;",
-            &[],
+            "SELECT * FROM experiments WHERE status != ?1 ORDER BY priority DESC, created_at;",
+            &[&Status::Completed.to_str()],
             |r| ExperimentDBRecord::from_row(r),
         )?;
         records
diff --git a/src/server/routes/ui/experiments.rs b/src/server/routes/ui/experiments.rs
@@ -65,7 +65,7 @@ pub fn endpoint_queue(data: Arc<Data>) -> Fallible<Response<Body>> {
     let mut generating_report = Vec::new();
     let mut report_failed = Vec::new();
 
-    for experiment in Experiment::all(&data.db)? {
+    for experiment in Experiment::unfinished(&data.db)? {
         // Don't include completed experiments in the queue
         if experiment.status == Status::Completed {
             continue;
