update

Author: tgross35

crates/symbol-check/src/main.rs

@@ -398,16 +398,26 @@ impl Archive {
     }
 }
 
+/// Check with a binary that has no `.note.GNU-stack` section, indicating platform-default stack
+/// writeability.
 #[test]
 fn check_no_gnu_stack_obj() {
     // Should be supported on all Unix platforms
     let p = env!("NO_GNU_STACK_OBJ");
     let f = fs::read(p).unwrap();
     let obj = ObjFile::parse(f.as_slice()).unwrap();
-    assert!(obj_requires_exe_stack(&obj));
+    let has_exe_stack = obj_requires_exe_stack(&obj);
+
+    if cfg!(target_os = "windows") || cfg!(target_vendor = "apple") {
+        // Non-ELF targets don't have executable stacks marked in the same way
+        assert!(!has_exe_stack);
+    } else {
+        assert!(has_exe_stack);
+    }
 }
 
 #[test]
+#[cfg_attr(not(target_env = "gnu"), ignore = "requires a gnu toolchain to build")]
 fn check_obj() {
     let p = option_env!("HAS_EXE_STACK_OBJ").expect("has_exe_stack.o not present");
     let f = fs::read(p).unwrap();