Merge pull request #392 from zaharidichev/zd/flounder-on-truncation

Stop leaking truncated goal

Author: jackh726

chalk-solve/src/solve/slg.rs

@@ -348,9 +348,7 @@ impl<I: Interner> TruncatingInferenceTable<I> {
 
 impl<I: Interner> context::TruncateOps<SlgContext<I>> for TruncatingInferenceTable<I> {
     fn goal_needs_truncation(&mut self, interner: &I, subgoal: &InEnvironment<Goal<I>>) -> bool {
-        // We only want to check the goal itself. We keep the environment intact.
-        // See rust-lang/chalk#280
-        truncate::needs_truncation(interner, &mut self.infer, self.max_size, &subgoal.goal)
+        truncate::needs_truncation(interner, &mut self.infer, self.max_size, &subgoal)
     }
 
     fn answer_needs_truncation(&mut self, interner: &I, subst: &Substitution<I>) -> bool {

tests/test/projection.rs

@@ -712,8 +712,8 @@ fn rust_analyzer_regression() {
                     PI: ParallelIterator
                 }
             }
-        } yields_all[SolverChoice::slg(4, None)] {
-            "substitution [], lifetime constraints []"
+        } yields_first[SolverChoice::slg(4, None)] {
+            "Floundered"
         }
     }
 }