Detect incorrectly named cargo.toml for install --git

Author: 0xPoe

src/cargo/ops/cargo_read_manifest.rs

@@ -88,10 +88,19 @@ pub fn read_packages(
     if all_packages.is_empty() {
         match errors.pop() {
             Some(err) => Err(err),
-            None => Err(anyhow::format_err!(
-                "Could not find Cargo.toml in `{}`",
+            None => {
+                if find_project_manifest_exact(path, "cargo.toml").is_ok() {
+                    Err(anyhow::format_err!(
+                "Could not find Cargo.toml in `{}`, but found cargo.toml please try to rename it to Cargo.toml",
                 path.display()
-            )),
+            ))
+                } else {
+                    Err(anyhow::format_err!(
+                        "Could not find Cargo.toml in `{}`",
+                        path.display()
+                    ))
+                }
+            }
         }
     } else {
         Ok(all_packages.into_iter().map(|(_, v)| v).collect())

tests/testsuite/install.rs

@@ -244,6 +244,53 @@ fn missing() {
         .run();
 }
 
+#[cargo_test]
+fn pkg_missing_cargo_toml() {
+    let p = project()
+        .file(
+            "Cargo1.toml",
+            r#"
+                [package]
+                name = "foo"
+                version = "0.1.0"
+                authors = []
+            "#,
+        )
+        .file("src/main.rs", "fn main() {}")
+        .build();
+
+    cargo_process("install")
+        .arg(p.root())
+        .with_status(101)
+        .with_stderr(
+            "\
+[UPDATING] [..] index
+[ERROR] could not find `[..]` in registry `[..]` with version `*`
+",
+        )
+        .run();
+}
+
+#[cargo_test]
+#[cfg(not(target_os = "macos"))]
+fn git_repository_missing_cargo_toml() {
+    let p = git::repo(&paths::root().join("foo"))
+        .file("cargo.toml", &basic_manifest("foo", "0.1.0"))
+        .file("src/main.rs", "fn main() {}")
+        .build();
+
+    cargo_process("install --git")
+        .arg(p.url().to_string())
+        .with_status(101)
+        .with_stderr(
+            "\
+[UPDATING] git repository [..]
+[ERROR] Could not find Cargo.toml in `[..]`, but found cargo.toml please try to rename it to Cargo.toml
+",
+        )
+        .run();
+}
+
 #[cargo_test]
 fn missing_current_working_directory() {
     cargo_process("install .")