feat: Don't check antivirus in cargo install

Author: madsmtm

src/cargo/core/compiler/build_config.rs

@@ -297,7 +297,7 @@ impl CompileMode {
 ///
 /// For example, when a user runs `cargo test`, the intent is [`UserIntent::Test`],
 /// but this might result in multiple [`CompileMode`]s for different units.
-#[derive(Clone, Copy, Debug)]
+#[derive(Clone, Copy, Debug, PartialEq, Eq, Hash)]
 pub enum UserIntent {
     /// Build benchmark binaries, e.g., `cargo bench`
     Bench,

src/cargo/ops/cargo_compile/mod.rs

@@ -561,9 +561,14 @@ where `<compatible-ver>` is the latest version supporting rustc {rustc_version}"
     }
 
     if build_config.detect_antivirus {
-        if let Err(err) = detect_antivirus::detect_and_report(gctx) {
-            // Errors in this detection are not fatal.
-            tracing::error!("failed detecting whether binaries may be slow to run: {err}");
+        // We don't want to do this check when installing, since there might
+        // be `cargo install` users who are not necessarily developers (and so
+        // the note will be irrelevant to them).
+        if build_config.intent != UserIntent::Install {
+            if let Err(err) = detect_antivirus::detect_and_report(gctx) {
+                // Errors in this detection are not fatal.
+                tracing::error!("failed detecting whether binaries may be slow to run: {err}");
+            }
         }
     }