Remove ordering hint

Author: JulianKnodt

compiler/rustc_typeck/src/astconv/generics.rs

@@ -70,7 +70,9 @@ impl<'o, 'tcx> dyn AstConv<'tcx> + 'o {
                     add_braces_suggestion(arg, &mut err);
                     err.set_primary_message(
                         "unresolved item provided when a constant was expected",
-                    );
+                    )
+                    .emit();
+                    return;
                 }
                 Res::Def(DefKind::TyParam, src_def_id) => {
                     if let Some(param_local_id) = param.def_id.as_local() {

src/test/ui/const-generics/diagnostics.stderr

@@ -41,8 +41,6 @@ error[E0747]: unresolved item provided when a constant was expected
 LL | impl<const N: u8> Foo for C<N, T> {}
    |                                ^
    |
-   = note: type arguments must be provided before constant arguments
-   = help: reorder the arguments: consts: `<C, N>`
 help: if this generic argument was intended as a const parameter, surround it with braces
    |
 LL | impl<const N: u8> Foo for C<N, { T }> {}