new_without_default

Urhengulas · Urhengulas · commit d37f4e0d2157 · 2024-01-31T19:06:36.000+01:00
diff --git a/Cargo.toml b/Cargo.toml
@@ -171,7 +171,6 @@ derived_hash_with_manual_eq = "allow"
 forget_non_drop = "allow"
 format_collect = "allow"
 needless_doctest_main = "allow"
-new_without_default = "allow"
 non_canonical_clone_impl = "allow"
 non_canonical_partial_ord_impl = "allow"
 self_named_constructors = "allow"
diff --git a/crates/hir-def/src/hir/format_args.rs b/crates/hir-def/src/hir/format_args.rs
@@ -433,7 +433,7 @@ pub(crate) fn parse(
     }
 }
 
-#[derive(Debug, Clone, PartialEq, Eq)]
+#[derive(Clone, Debug, Default, Eq, PartialEq)]
 pub struct FormatArgumentsCollector {
     arguments: Vec<FormatArgument>,
     num_unnamed_args: usize,
@@ -452,7 +452,7 @@ impl FormatArgumentsCollector {
     }
 
     pub fn new() -> Self {
-        Self { arguments: vec![], names: vec![], num_unnamed_args: 0, num_explicit_args: 0 }
+        Default::default()
     }
 
     pub fn add(&mut self, arg: FormatArgument) -> usize {

Original file line number	Diff line number	Diff line change
`@@ -433,7 +433,7 @@ pub(crate) fn parse(`
`433`	`433`	`}`
`434`	`434`	`}`
`435`	`435`
`436`		`-#[derive(Debug, Clone, PartialEq, Eq)]`
	`436`	`+#[derive(Clone, Debug, Default, Eq, PartialEq)]`
`437`	`437`	`pub struct FormatArgumentsCollector {`
`438`	`438`	`arguments: Vec<FormatArgument>,`
`439`	`439`	`num_unnamed_args: usize,`
`@@ -452,7 +452,7 @@ impl FormatArgumentsCollector {`
`452`	`452`	`}`
`453`	`453`
`454`	`454`	`pub fn new() -> Self {`
`455`		`- Self { arguments: vec![], names: vec![], num_unnamed_args: 0, num_explicit_args: 0 }`
	`455`	`+ Default::default()`
`456`	`456`	`}`
`457`	`457`
`458`	`458`	`pub fn add(&mut self, arg: FormatArgument) -> usize {`