remove more redundant clones manually

Author: matthiaskrgr

crates/hir-ty/src/infer/pat.rs

@@ -233,7 +233,6 @@ impl InferenceContext<'_> {
         };
         let mut expectations_iter = expectations
             .iter()
-            .cloned()
             .map(|a| a.assert_ty_ref(Interner).clone())
             .chain(repeat_with(|| self.table.new_type_var()));
 

crates/hir/src/lib.rs

@@ -3673,7 +3673,6 @@ impl Closure {
         let (captures, _) = infer.closure_info(&self.id);
         captures
             .iter()
-            .cloned()
             .map(|capture| Type {
                 env: db.trait_environment_for_body(owner),
                 ty: capture.ty(&self.subst),

crates/ide/src/goto_definition.rs

@@ -79,7 +79,7 @@ pub(crate) fn goto_definition(
                     return Some(vec![x]);
                 }
 
-                if let Some(x) = try_lookup_macro_def_in_macro_use(sema, token.clone()) {
+                if let Some(x) = try_lookup_macro_def_in_macro_use(sema, token) {
                     return Some(vec![x]);
                 }
             }

crates/ide/src/view_memory_layout.rs

@@ -69,7 +69,7 @@ impl FieldOrTupleIdx {
                 .as_str()
                 .map(|s| s.to_owned())
                 .unwrap_or_else(|| format!(".{}", f.name(db).as_tuple_index().unwrap())),
-            FieldOrTupleIdx::TupleIdx(i) => format!(".{i}").to_owned(),
+            FieldOrTupleIdx::TupleIdx(i) => format!(".{i}"),
         }
     }
 }
@@ -203,7 +203,7 @@ pub(crate) fn view_memory_layout(
 
             let mut nodes = vec![MemoryLayoutNode {
                 item_name,
-                typename: typename.clone(),
+                typename,
                 size: layout.size(),
                 offset: 0,
                 alignment: layout.align(),