add additional testcases

Author: Jacherr

clippy_lints/src/indexing_slicing.rs

@@ -262,11 +262,6 @@ fn ty_has_appliciable_get_function<'tcx>(
         && cx.tcx.is_diagnostic_item(sym::Option, def.0.did)
         && let Some(option_generic_param) = args.get(0)
         && let generic_ty = option_generic_param.expect_ty().peel_refs()
-        && let _ = println!(
-            "{}, {}",
-            cx.typeck_results().expr_ty(index_expr).peel_refs(),
-            generic_ty.peel_refs()
-        )
         && cx.typeck_results().expr_ty(index_expr).peel_refs() == generic_ty.peel_refs()
     {
         true

tests/ui/indexing_slicing_slice.rs

@@ -47,6 +47,45 @@ impl<T> BoolMapWithGet<T> {
     }
 }
 
+struct S<T>(T);
+impl S<i32> {
+    fn get() -> Option<i32> {
+        unimplemented!()
+    }
+}
+impl<T> Index<i32> for S<T> {
+    type Output = T;
+    fn index(&self, _index: i32) -> &Self::Output {
+        &self.0
+    }
+}
+
+struct Y<T>(T);
+impl Y<i32> {
+    fn get<U>() -> Option<U> {
+        unimplemented!()
+    }
+}
+impl<T> Index<i32> for Y<T> {
+    type Output = T;
+    fn index(&self, _index: i32) -> &Self::Output {
+        &self.0
+    }
+}
+
+struct Z<T>(T);
+impl<T> Z<T> {
+    fn get<T2>() -> T2 {
+        todo!()
+    }
+}
+impl<T> Index<i32> for Z<T> {
+    type Output = T;
+    fn index(&self, _index: i32) -> &Self::Output {
+        &self.0
+    }
+}
+
 fn main() {
     let x = [1, 2, 3, 4];
     let index: usize = 1;
@@ -109,4 +148,13 @@ fn main() {
 
     // Lint on this, because `get` does exist with same signature
     map_with_get[true];
+
+    let s = S::<i32>(1);
+    s[0];
+
+    let y = Y::<i32>(1);
+    y[0];
+
+    let z = Z::<i32>(1);
+    z[0];
 }

tests/ui/indexing_slicing_slice.stderr

@@ -1,5 +1,5 @@
 error: slicing may panic
-  --> tests/ui/indexing_slicing_slice.rs:27:6
+  --> tests/ui/indexing_slicing_slice.rs:81:6
    |
 LL |     &x[index..];
    |      ^^^^^^^^^^
@@ -9,47 +9,47 @@ LL |     &x[index..];
    = help: to override `-D warnings` add `#[allow(clippy::indexing_slicing)]`
 
 error: slicing may panic
-  --> tests/ui/indexing_slicing_slice.rs:29:6
+  --> tests/ui/indexing_slicing_slice.rs:83:6
    |
 LL |     &x[..index];
    |      ^^^^^^^^^^
    |
    = help: consider using `.get(..n)`or `.get_mut(..n)` instead
 
 error: slicing may panic
-  --> tests/ui/indexing_slicing_slice.rs:31:6
+  --> tests/ui/indexing_slicing_slice.rs:85:6
    |
 LL |     &x[index_from..index_to];
    |      ^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider using `.get(n..m)` or `.get_mut(n..m)` instead
 
 error: slicing may panic
-  --> tests/ui/indexing_slicing_slice.rs:33:6
+  --> tests/ui/indexing_slicing_slice.rs:87:6
    |
 LL |     &x[index_from..][..index_to];
    |      ^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: consider using `.get(..n)`or `.get_mut(..n)` instead
 
 error: slicing may panic
-  --> tests/ui/indexing_slicing_slice.rs:33:6
+  --> tests/ui/indexing_slicing_slice.rs:87:6
    |
 LL |     &x[index_from..][..index_to];
    |      ^^^^^^^^^^^^^^^
    |
    = help: consider using `.get(n..)` or .get_mut(n..)` instead
 
 error: slicing may panic
-  --> tests/ui/indexing_slicing_slice.rs:36:6
+  --> tests/ui/indexing_slicing_slice.rs:90:6
    |
 LL |     &x[5..][..10];
    |      ^^^^^^^^^^^^
    |
    = help: consider using `.get(..n)`or `.get_mut(..n)` instead
 
 error: range is out of bounds
-  --> tests/ui/indexing_slicing_slice.rs:36:8
+  --> tests/ui/indexing_slicing_slice.rs:90:8
    |
 LL |     &x[5..][..10];
    |        ^
@@ -58,70 +58,94 @@ LL |     &x[5..][..10];
    = help: to override `-D warnings` add `#[allow(clippy::out_of_bounds_indexing)]`
 
 error: slicing may panic
-  --> tests/ui/indexing_slicing_slice.rs:40:6
+  --> tests/ui/indexing_slicing_slice.rs:94:6
    |
 LL |     &x[0..][..3];
    |      ^^^^^^^^^^^
    |
    = help: consider using `.get(..n)`or `.get_mut(..n)` instead
 
 error: slicing may panic
-  --> tests/ui/indexing_slicing_slice.rs:42:6
+  --> tests/ui/indexing_slicing_slice.rs:96:6
    |
 LL |     &x[1..][..5];
    |      ^^^^^^^^^^^
    |
    = help: consider using `.get(..n)`or `.get_mut(..n)` instead
 
 error: range is out of bounds
-  --> tests/ui/indexing_slicing_slice.rs:50:12
+  --> tests/ui/indexing_slicing_slice.rs:104:12
    |
 LL |     &y[0..=4];
    |            ^
 
 error: range is out of bounds
-  --> tests/ui/indexing_slicing_slice.rs:52:11
+  --> tests/ui/indexing_slicing_slice.rs:106:11
    |
 LL |     &y[..=4];
    |           ^
 
 error: slicing may panic
-  --> tests/ui/indexing_slicing_slice.rs:58:6
+  --> tests/ui/indexing_slicing_slice.rs:112:6
    |
 LL |     &v[10..100];
    |      ^^^^^^^^^^
    |
    = help: consider using `.get(n..m)` or `.get_mut(n..m)` instead
 
 error: slicing may panic
-  --> tests/ui/indexing_slicing_slice.rs:60:6
+  --> tests/ui/indexing_slicing_slice.rs:114:6
    |
 LL |     &x[10..][..100];
    |      ^^^^^^^^^^^^^^
    |
    = help: consider using `.get(..n)`or `.get_mut(..n)` instead
 
 error: range is out of bounds
-  --> tests/ui/indexing_slicing_slice.rs:60:8
+  --> tests/ui/indexing_slicing_slice.rs:114:8
    |
 LL |     &x[10..][..100];
    |        ^^
 
 error: slicing may panic
-  --> tests/ui/indexing_slicing_slice.rs:63:6
+  --> tests/ui/indexing_slicing_slice.rs:117:6
    |
 LL |     &v[10..];
    |      ^^^^^^^
    |
    = help: consider using `.get(n..)` or .get_mut(n..)` instead
 
 error: slicing may panic
-  --> tests/ui/indexing_slicing_slice.rs:65:6
+  --> tests/ui/indexing_slicing_slice.rs:119:6
    |
 LL |     &v[..100];
    |      ^^^^^^^^
    |
    = help: consider using `.get(..n)`or `.get_mut(..n)` instead
 
-error: aborting due to 16 previous errors
+error: indexing may panic
+  --> tests/ui/indexing_slicing_slice.rs:137:5
+   |
+LL |     map_with_get[true];
+   |     ^^^^^^^^^^^^^^^^^^
+   |
+   = help: consider using `.get(n)` or `.get_mut(n)` instead
+
+error: indexing may panic
+  --> tests/ui/indexing_slicing_slice.rs:140:5
+   |
+LL |     s[0];
+   |     ^^^^
+   |
+   = help: consider using `.get(n)` or `.get_mut(n)` instead
+
+error: indexing may panic
+  --> tests/ui/indexing_slicing_slice.rs:143:5
+   |
+LL |     y[0];
+   |     ^^^^
+   |
+   = help: consider using `.get(n)` or `.get_mut(n)` instead
+
+error: aborting due to 19 previous errors