Small refactoring: irrefutable let pattern

Author: wowinter13

clippy_lints/src/methods/sliced_string_as_bytes.rs

@@ -10,21 +10,20 @@ use super::SLICED_STRING_AS_BYTES;
 pub(super) fn check(cx: &LateContext<'_>, expr: &Expr<'_>, recv: &Expr<'_>) {
     if let ExprKind::Index(indexed, index, _) = recv.kind
         && is_range_literal(index)
+        && let ty = cx.typeck_results().expr_ty(indexed).peel_refs()
+        && (ty.is_str() || is_type_lang_item(cx, ty, LangItem::String))
     {
-        let ty = cx.typeck_results().expr_ty(indexed).peel_refs();
-        if ty.is_str() || is_type_lang_item(cx, ty, LangItem::String) {
-            let mut applicability = Applicability::MaybeIncorrect;
-            let stringish = snippet_with_applicability(cx, indexed.span, "..", &mut applicability);
-            let range = snippet_with_applicability(cx, index.span, "..", &mut applicability);
-            span_lint_and_sugg(
-                cx,
-                SLICED_STRING_AS_BYTES,
-                expr.span,
-                "calling `as_bytes` after slicing a string",
-                "try",
-                format!("&{stringish}.as_bytes()[{range}]"),
-                applicability,
-            );
-        }
+        let mut applicability = Applicability::MaybeIncorrect;
+        let stringish = snippet_with_applicability(cx, indexed.span, "..", &mut applicability);
+        let range = snippet_with_applicability(cx, index.span, "..", &mut applicability);
+        span_lint_and_sugg(
+            cx,
+            SLICED_STRING_AS_BYTES,
+            expr.span,
+            "calling `as_bytes` after slicing a string",
+            "try",
+            format!("&{stringish}.as_bytes()[{range}]"),
+            applicability,
+        );
     }
 }