Change stable hasher to Blake3

Urgau · Urgau · commit 56eeec98b9e7 · 2024-07-15T10:42:43.000+02:00
diff --git a/Cargo.lock b/Cargo.lock
@@ -243,6 +243,12 @@ dependencies = [
  "object 0.32.2",
 ]
 
+[[package]]
+name = "arrayref"
+version = "0.3.7"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "6b4930d2cb77ce62f89ee5d5289b4ac049559b1c45539271f5ed4fdc7db34545"
+
 [[package]]
 name = "arrayvec"
 version = "0.7.4"
@@ -362,6 +368,19 @@ version = "2.5.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "cf4b9d6a944f767f8e5e0db018570623c85f3d925ac718db4e06d0187adb21c1"
 
+[[package]]
+name = "blake3"
+version = "1.5.3"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "e9ec96fe9a81b5e365f9db71fe00edc4fe4ca2cc7dcb7861f0603012a7caa210"
+dependencies = [
+ "arrayref",
+ "arrayvec",
+ "cc",
+ "cfg-if",
+ "constant_time_eq",
+]
+
 [[package]]
 name = "block-buffer"
 version = "0.10.4"
@@ -848,6 +867,12 @@ dependencies = [
  "windows-sys 0.52.0",
 ]
 
+[[package]]
+name = "constant_time_eq"
+version = "0.3.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "f7144d30dcf0fafbce74250a3963025d8d52177934239851c917d29f1df280c2"
+
 [[package]]
 name = "core"
 version = "0.0.0"
@@ -3518,8 +3543,10 @@ checksum = "5be1bdc7edf596692617627bbfeaba522131b18e06ca4df2b6b689e3c5d5ce84"
 [[package]]
 name = "rustc-stable-hash"
 version = "0.1.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "e5c9f15eec8235d7cb775ee6f81891db79b98fd54ba1ad8fae565b88ef1ae4e2"
+source = "git+https://github.com/Urgau/rustc-stable-hash.git?rev=368f4ef#368f4ef468ca97fd4757c896f53349d9fa4def1b"
+dependencies = [
+ "blake3",
+]
 
 [[package]]
 name = "rustc-std-workspace-alloc"
diff --git a/compiler/rustc_data_structures/Cargo.toml b/compiler/rustc_data_structures/Cargo.toml
@@ -15,7 +15,7 @@ jobserver_crate = { version = "0.1.28", package = "jobserver" }
 measureme = "11"
 rustc-hash = "1.1.0"
 rustc-rayon = { version = "0.5.0", optional = true }
-rustc-stable-hash = { version = "0.1.0", features = ["nightly"] }
+rustc-stable-hash = { git = "https://github.com/Urgau/rustc-stable-hash.git", rev = "368f4ef", features = ["nightly", "blake3"] }
 rustc_arena = { path = "../rustc_arena" }
 rustc_graphviz = { path = "../rustc_graphviz" }
 rustc_index = { path = "../rustc_index", package = "rustc_index" }
diff --git a/compiler/rustc_data_structures/src/fingerprint.rs b/compiler/rustc_data_structures/src/fingerprint.rs
@@ -158,8 +158,12 @@ impl FromStableHash for Fingerprint {
     type Hash = StableHasherHash;
 
     #[inline]
-    fn from(StableHasherHash([_0, _1]): Self::Hash) -> Self {
-        Fingerprint(_0, _1)
+    fn from(hash: Self::Hash) -> Self {
+        let bytes = hash.as_bytes();
+        Fingerprint(
+            u64::from_ne_bytes(bytes[0..8].try_into().unwrap()),
+            u64::from_ne_bytes(bytes[8..16].try_into().unwrap()),
+        )
     }
 }
 
diff --git a/compiler/rustc_data_structures/src/hashes.rs b/compiler/rustc_data_structures/src/hashes.rs
@@ -60,8 +60,9 @@ impl FromStableHash for Hash64 {
     type Hash = StableHasherHash;
 
     #[inline]
-    fn from(StableHasherHash([_0, __1]): Self::Hash) -> Self {
-        Self { inner: _0 }
+    fn from(hash: Self::Hash) -> Self {
+        let bytes = hash.as_bytes();
+        Self { inner: u64::from_ne_bytes(bytes[0..8].try_into().unwrap()) }
     }
 }
 
@@ -127,8 +128,9 @@ impl FromStableHash for Hash128 {
     type Hash = StableHasherHash;
 
     #[inline]
-    fn from(StableHasherHash([_0, _1]): Self::Hash) -> Self {
-        Self { inner: u128::from(_0) | (u128::from(_1) << 64) }
+    fn from(hash: Self::Hash) -> Self {
+        let bytes = hash.as_bytes();
+        Self { inner: u128::from_ne_bytes(bytes[0..16].try_into().unwrap()) }
     }
 }
 
diff --git a/compiler/rustc_data_structures/src/stable_hasher.rs b/compiler/rustc_data_structures/src/stable_hasher.rs
@@ -11,9 +11,9 @@ mod tests;
 
 pub use crate::hashes::{Hash128, Hash64};
 
+pub use rustc_stable_hash::hashers::Blake3Hash as StableHasherHash;
+pub use rustc_stable_hash::hashers::StableBlake3Hasher as StableHasher;
 pub use rustc_stable_hash::FromStableHash;
-pub use rustc_stable_hash::SipHasher128Hash as StableHasherHash;
-pub use rustc_stable_hash::StableSipHasher128 as StableHasher;
 
 /// Something that implements `HashStable<CTX>` can be hashed in a way that is
 /// stable across multiple compilation sessions.

Original file line number	Diff line number	Diff line change
`@@ -158,8 +158,12 @@ impl FromStableHash for Fingerprint {`
`158`	`158`	`type Hash = StableHasherHash;`
`159`	`159`
`160`	`160`	`#[inline]`
`161`		`- fn from(StableHasherHash([_0, _1]): Self::Hash) -> Self {`
`162`		`- Fingerprint(_0, _1)`
	`161`	`+ fn from(hash: Self::Hash) -> Self {`
	`162`	`+ let bytes = hash.as_bytes();`
	`163`	`+ Fingerprint(`
	`164`	`+ u64::from_ne_bytes(bytes[0..8].try_into().unwrap()),`
	`165`	`+ u64::from_ne_bytes(bytes[8..16].try_into().unwrap()),`
	`166`	`+ )`
`163`	`167`	`}`
`164`	`168`	`}`
`165`	`169`
Original file line number	Diff line number	Diff line change
`@@ -60,8 +60,9 @@ impl FromStableHash for Hash64 {`
`60`	`60`	`type Hash = StableHasherHash;`
`61`	`61`
`62`	`62`	`#[inline]`
`63`		`- fn from(StableHasherHash([_0, __1]): Self::Hash) -> Self {`
`64`		`- Self { inner: _0 }`
	`63`	`+ fn from(hash: Self::Hash) -> Self {`
	`64`	`+ let bytes = hash.as_bytes();`
	`65`	`+ Self { inner: u64::from_ne_bytes(bytes[0..8].try_into().unwrap()) }`
`65`	`66`	`}`
`66`	`67`	`}`
`67`	`68`
`@@ -127,8 +128,9 @@ impl FromStableHash for Hash128 {`
`127`	`128`	`type Hash = StableHasherHash;`
`128`	`129`
`129`	`130`	`#[inline]`
`130`		`- fn from(StableHasherHash([_0, _1]): Self::Hash) -> Self {`
`131`		`- Self { inner: u128::from(_0) \| (u128::from(_1) << 64) }`
	`131`	`+ fn from(hash: Self::Hash) -> Self {`
	`132`	`+ let bytes = hash.as_bytes();`
	`133`	`+ Self { inner: u128::from_ne_bytes(bytes[0..16].try_into().unwrap()) }`
`132`	`134`	`}`
`133`	`135`	`}`
`134`	`136`