Check in push_suggestion

Author: long-long-float

compiler/rustc_errors/src/diagnostic.rs

@@ -519,6 +519,15 @@ impl Diagnostic {
 
     /// Helper for pushing to `self.suggestions`, if available (not disable).
     fn push_suggestion(&mut self, suggestion: CodeSuggestion) {
+        let in_derive = suggestion
+            .substitutions
+            .iter()
+            .any(|subst| subst.parts.iter().any(|part| part.span.in_derive_expansion()));
+        if in_derive {
+            // Ignore if spans is from derive macro.
+            return;
+        }
+
         if let Ok(suggestions) = &mut self.suggestions {
             suggestions.push(suggestion);
         }

compiler/rustc_hir_typeck/src/fn_ctxt/suggestions.rs

@@ -2698,11 +2698,6 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
             return false;
         }
 
-        if expr.span.in_derive_expansion() {
-            // Ignore if span is from derive macro.
-            return false;
-        }
-
         let Ok(src) = self.tcx.sess.source_map().span_to_snippet(expr.span) else {
             return false;
         };