Rollup merge of rust-lang#102577 - kornelski:non-code-visual-studio, r=wesleywiser

matthiaskrgr · web-flow · commit 1a2a3249bc73 · 2022-10-07T07:28:09.000+02:00
Warn about Visual Studio Code branding confusion VS Code is a popular companion for Rust, but Microsoft's branding is confusing, and users [may not understand](https://users.rust-lang.org/t/complie-error-when-i-run-rustc/82127) they also need the *other* VS.
diff --git a/compiler/rustc_codegen_ssa/src/back/link.rs b/compiler/rustc_codegen_ssa/src/back/link.rs
@@ -979,9 +979,10 @@ fn link_natively<'a>(
                      but `link.exe` was not found",
                 );
                 sess.note_without_error(
-                    "please ensure that VS 2013, VS 2015, VS 2017, VS 2019 or VS 2022 \
-                     was installed with the Visual C++ option",
+                    "please ensure that Visual Studio 2017 or later, or Build Tools \
+                     for Visual Studio were installed with the Visual C++ option.",
                 );
+                sess.note_without_error("VS Code is a different product, and is not sufficient.");
             }
             sess.abort_if_errors();
         }

Original file line number	Diff line number	Diff line change
`@@ -979,9 +979,10 @@ fn link_natively<'a>(`
`979`	`979`	but `link.exe` was not found",
`980`	`980`	`);`
`981`	`981`	`sess.note_without_error(`
`982`		`- "please ensure that VS 2013, VS 2015, VS 2017, VS 2019 or VS 2022 \`
`983`		`- was installed with the Visual C++ option",`
	`982`	`+ "please ensure that Visual Studio 2017 or later, or Build Tools \`
	`983`	`+ for Visual Studio were installed with the Visual C++ option.",`
`984`	`984`	`);`
	`985`	`+ sess.note_without_error("VS Code is a different product, and is not sufficient.");`
`985`	`986`	`}`
`986`	`987`	`sess.abort_if_errors();`
`987`	`988`	`}`