Skip to content

feat: impl PeekingNext for std::collections::* #1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: impl PeekingNext for std::collections::* #1073

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0559142
mark: aatifsyed/peeking-next-btree
aatifsyed Nov 4, 2025
da8dee1
feat: impl PeekingNext for std::collections::*
aatifsyed Nov 4, 2025
b51f076
fix: feature gating
aatifsyed Nov 4, 2025
8c7e761
chore: feature gate style
aatifsyed Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions src/peeking_take_while.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,10 +242,28 @@ peeking_next_by_clone! { ['a] ::std::str::Bytes<'a> }
peeking_next_by_clone! { ['a, T] ::std::option::Iter<'a, T> }
peeking_next_by_clone! { ['a, T] ::std::result::Iter<'a, T> }
peeking_next_by_clone! { [T] ::std::iter::Empty<T> }

#[cfg(feature = "use_alloc")]
peeking_next_by_clone! { ['a, T] alloc::collections::linked_list::Iter<'a, T> }
#[cfg(feature = "use_alloc")]
peeking_next_by_clone! { ['a, T] alloc::collections::vec_deque::Iter<'a, T> }
const _: () = {
Copy link
Member

@phimuemue phimuemue Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace then const _ with repeated gates.

If we start adopting this pattern, we should do it consistently and not arbitrarily only here.

peeking_next_by_clone! { ['a, T] alloc::collections::linked_list::Iter<'a, T> }
peeking_next_by_clone! { ['a, T] alloc::collections::vec_deque::Iter<'a, T> }

peeking_next_by_clone! { ['a, K, V] alloc::collections::btree_map::Iter<'a, K, V> }
peeking_next_by_clone! { ['a, K, V] alloc::collections::btree_map::Keys<'a, K, V> }
peeking_next_by_clone! { ['a, K, V] alloc::collections::btree_map::Values<'a, K, V> }

peeking_next_by_clone! { ['a, T] alloc::collections::btree_set::Iter<'a, T> }
peeking_next_by_clone! { ['a, T] alloc::collections::binary_heap::Iter<'a, T> }
};

#[cfg(feature = "use_std")]
const _: () = {
peeking_next_by_clone! { ['a, K, V] std::collections::hash_map::Iter<'a, K, V> }
peeking_next_by_clone! { ['a, K, V] std::collections::hash_map::Keys<'a, K, V> }
peeking_next_by_clone! { ['a, K, V] std::collections::hash_map::Values<'a, K, V> }

peeking_next_by_clone! { ['a, T] std::collections::hash_set::Iter<'a, T> }
};

// cloning a Rev has no extra overhead; peekable and put backs are never DEI.
peeking_next_by_clone! { [I: Clone + PeekingNext + DoubleEndedIterator]
Expand Down
Loading