fix clippy::if_not_else

Author: hellow554

src/combinations_with_replacement.rs

@@ -65,13 +65,13 @@ where
     fn next(&mut self) -> Option<Self::Item> {
         // If this is the first iteration, return early
         if self.first {
-            // In empty edge cases, stop iterating immediately
-            return if !(self.indices.is_empty() || self.pool.get_next()) {
-                None
-            // Otherwise, yield the initial state
-            } else {
+            return if self.indices.is_empty() || self.pool.get_next() {
+                // yield the initial state
                 self.first = false;
                 Some(self.current())
+            } else {
+                // In empty edge cases, stop iterating immediately
+                None
             };
         }
 

src/minmax.rs

@@ -91,16 +91,7 @@ where
         };
         let first_key = key_for(&first);
         let second_key = key_for(&second);
-        if !lt(&second, &first, &second_key, &first_key) {
-            if lt(&first, &min, &first_key, &min_key) {
-                min = first;
-                min_key = first_key;
-            }
-            if !lt(&second, &max, &second_key, &max_key) {
-                max = second;
-                max_key = second_key;
-            }
-        } else {
+        if lt(&second, &first, &second_key, &first_key) {
             if lt(&second, &min, &second_key, &min_key) {
                 min = second;
                 min_key = second_key;
@@ -109,6 +100,15 @@ where
                 max = first;
                 max_key = first_key;
             }
+        } else {
+            if lt(&first, &min, &first_key, &min_key) {
+                min = first;
+                min_key = first_key;
+            }
+            if !lt(&second, &max, &second_key, &max_key) {
+                max = second;
+                max_key = second_key;
+            }
         }
     }
 

src/with_position.rs

@@ -55,7 +55,14 @@ impl<I: Iterator> Iterator for WithPosition<I> {
     fn next(&mut self) -> Option<Self::Item> {
         match self.peekable.next() {
             Some(item) => {
-                if !self.handled_first {
+                if self.handled_first {
+                    // Have seen the first item, and there's something left.
+                    // Peek to see if this is the last item.
+                    match self.peekable.peek() {
+                        Some(_) => Some((Position::Middle, item)),
+                        None => Some((Position::Last, item)),
+                    }
+                } else {
                     // Haven't seen the first item yet, and there is one to give.
                     self.handled_first = true;
                     // Peek to see if this is also the last item,
@@ -64,13 +71,6 @@ impl<I: Iterator> Iterator for WithPosition<I> {
                         Some(_) => Some((Position::First, item)),
                         None => Some((Position::Only, item)),
                     }
-                } else {
-                    // Have seen the first item, and there's something left.
-                    // Peek to see if this is the last item.
-                    match self.peekable.peek() {
-                        Some(_) => Some((Position::Middle, item)),
-                        None => Some((Position::Last, item)),
-                    }
                 }
             }
             // Iterator is finished.