fix clippy::if_not_else

Author: hellow554

src/combinations_with_replacement.rs

@@ -63,13 +63,13 @@ where
     fn next(&mut self) -> Option<Self::Item> {
         // If this is the first iteration, return early
         if self.first {
-            // In empty edge cases, stop iterating immediately
-            return if !(self.indices.is_empty() || self.pool.get_next()) {
-                None
-            // Otherwise, yield the initial state
-            } else {
+            return if self.indices.is_empty() || self.pool.get_next() {
+                // yield the initial state
                 self.first = false;
                 Some(self.current())
+            } else {
+                // In empty edge cases, stop iterating immediately
+                None
             };
         }
 

src/minmax.rs

@@ -60,7 +60,7 @@ pub fn minmax_impl<I, K, F, L>(mut it: I, mut key_for: F,
                 Some(y) => {
                     let xk = key_for(&x);
                     let yk = key_for(&y);
-                    if !lt(&y, &x, &yk, &xk) {(x, y, xk, yk)} else {(y, x, yk, xk)}
+                    if lt(&y, &x, &yk, &xk) {(y, x, yk, xk)} else {(x, y, xk, yk)}
                 }
             }
         }
@@ -90,16 +90,7 @@ pub fn minmax_impl<I, K, F, L>(mut it: I, mut key_for: F,
         };
         let first_key = key_for(&first);
         let second_key = key_for(&second);
-        if !lt(&second, &first, &second_key, &first_key) {
-            if lt(&first, &min, &first_key, &min_key) {
-                min = first;
-                min_key = first_key;
-            }
-            if !lt(&second, &max, &second_key, &max_key) {
-                max = second;
-                max_key = second_key;
-            }
-        } else {
+        if lt(&second, &first, &second_key, &first_key) {
             if lt(&second, &min, &second_key, &min_key) {
                 min = second;
                 min_key = second_key;
@@ -108,6 +99,15 @@ pub fn minmax_impl<I, K, F, L>(mut it: I, mut key_for: F,
                 max = first;
                 max_key = first_key;
             }
+        } else {
+            if lt(&first, &min, &first_key, &min_key) {
+                min = first;
+                min_key = first_key;
+            }
+            if !lt(&second, &max, &second_key, &max_key) {
+                max = second;
+                max_key = second_key;
+            }
         }
     }
 

src/with_position.rs

@@ -64,7 +64,14 @@ impl<I: Iterator> Iterator for WithPosition<I> {
     fn next(&mut self) -> Option<Self::Item> {
         match self.peekable.next() {
             Some(item) => {
-                if !self.handled_first {
+                if self.handled_first {
+                    // Have seen the first item, and there's something left.
+                    // Peek to see if this is the last item.
+                    match self.peekable.peek() {
+                        Some(_) => Some(Position::Middle(item)),
+                        None => Some(Position::Last(item)),
+                    }
+                } else {
                     // Haven't seen the first item yet, and there is one to give.
                     self.handled_first = true;
                     // Peek to see if this is also the last item,
@@ -73,13 +80,6 @@ impl<I: Iterator> Iterator for WithPosition<I> {
                         Some(_) => Some(Position::First(item)),
                         None => Some(Position::Only(item)),
                     }
-                } else {
-                    // Have seen the first item, and there's something left.
-                    // Peek to see if this is the last item.
-                    match self.peekable.peek() {
-                        Some(_) => Some(Position::Middle(item)),
-                        None => Some(Position::Last(item)),
-                    }
                 }
             }
             // Iterator is finished.