Merge pull request #233 from kossnikita/feature/write-constraint-check

add write constraint range check

Author: burrbull

svd-rs/src/field.rs

@@ -312,6 +312,11 @@ impl FieldInfo {
                 _ => return Err(Error::IncompatibleEnumeratedValues.into()),
             }
         }
+
+        if let Some(WriteConstraint::Range(constraint)) = self.write_constraint {
+            constraint.check_range(0..2_u64.pow(self.bit_range.width))?;
+        }
+
         Ok(())
     }
 

svd-rs/src/lib.rs

@@ -166,6 +166,9 @@ pub enum SvdError {
     /// RegisterProperties error
     #[error("`RegisterProperties error: {0}")]
     RegisterProperties(#[from] registerproperties::Error),
+    /// WriteConstraint error
+    #[error("`WriteConstraint error: {0}")]
+    WriteConstraint(#[from] writeconstraint::Error),
 }
 
 /// Errors from a builder

svd-rs/src/writeconstraint.rs

@@ -1,3 +1,5 @@
+use super::SvdError;
+
 /// Define constraints for writing values to a field
 #[cfg_attr(
     feature = "serde",
@@ -25,3 +27,28 @@ pub struct WriteConstraintRange {
     #[cfg_attr(feature = "serde", serde(rename = "maximum"))]
     pub max: u64,
 }
+
+/// Errors for [`WriteConstraintRange::check_range`]
+#[derive(Clone, Debug, PartialEq, Eq, thiserror::Error)]
+pub enum Error {
+    /// The value is not in range.
+    #[error("Value {0} out of range {1:?}")]
+    OutOfRange(u64, core::ops::Range<u64>),
+    /// Minimum is greater than maximum.
+    #[error("Range minimum {0} is greater than maximum {1}")]
+    ReversedRange(u64, u64),
+}
+
+impl WriteConstraintRange {
+    pub(crate) fn check_range(&self, range: core::ops::Range<u64>) -> Result<(), SvdError> {
+        if self.min > self.max {
+            return Err(Error::ReversedRange(self.min, self.max).into());
+        }
+        for v in [&self.min, &self.max] {
+            if !range.contains(v) {
+                return Err(Error::OutOfRange(*v, range.clone()).into());
+            }
+        }
+        Ok(())
+    }
+}