Merge pull request #184 from matthiasbeyer/config-only-default-constructor

Remove Config::new()

Author: matthiasbeyer

src/config.rs

@@ -39,24 +39,24 @@ impl Default for ConfigKind {
 /// A prioritized configuration repository. It maintains a set of
 /// configuration sources, fetches values to populate those, and provides
 /// them according to the source's priority.
-#[derive(Default, Clone, Debug)]
+#[derive(Clone, Debug)]
 pub struct Config {
     kind: ConfigKind,
 
     /// Root of the cached configuration.
     pub cache: Value,
 }
 
-impl Config {
-    pub fn new() -> Self {
-        Self {
+impl Default for Config {
+    fn default() -> Self {
+        Config {
             kind: ConfigKind::default(),
-            // Config root should be instantiated as an empty table
-            // to avoid deserialization errors.
             cache: Value::new(None, Table::new()),
         }
     }
+}
 
+impl Config {
     /// Merge in a configuration property source.
     pub fn merge<T>(&mut self, source: T) -> Result<&mut Config>
     where

tests/defaults.rs

@@ -21,7 +21,7 @@ impl Default for Settings {
 
 #[test]
 fn set_defaults() {
-    let c = Config::new();
+    let c = Config::default();
     let s: Settings = c.try_into().expect("Deserialization failed");
 
     assert_eq!(s.db_host, "default");

tests/empty.rs

@@ -15,7 +15,9 @@ struct Settings {
 
 #[test]
 fn empty_deserializes() {
-    let s: Settings = Config::new().try_into().expect("Deserialization failed");
+    let s: Settings = Config::default()
+        .try_into()
+        .expect("Deserialization failed");
     assert_eq!(s.foo, 0);
     assert_eq!(s.bar, 0);
 }

tests/errors.rs

@@ -120,7 +120,7 @@ inner:
     test: ABC
 "#;
 
-    let mut cfg = Config::new();
+    let mut cfg = Config::default();
     cfg.merge(File::from_str(CFG, FileFormat::Yaml)).unwrap();
     let e = cfg.try_into::<Outer>().unwrap_err();
     if let ConfigError::Type {