Requiring for array newtypes to manually derive Copy

Author: dr-orlovsky

secp256k1-sys/src/lib.rs

@@ -99,6 +99,7 @@ pub type SchnorrNonceFn = Option<unsafe extern "C" fn(
 
 /// Library-internal representation of a Secp256k1 public key
 #[repr(C)]
+#[derive(Copy)]
 pub struct PublicKey([c_uchar; 64]);
 impl_array_newtype!(PublicKey, c_uchar, 64);
 impl_raw_debug!(PublicKey);
@@ -141,6 +142,7 @@ impl hash::Hash for PublicKey {
 
 /// Library-internal representation of a Secp256k1 signature
 #[repr(C)]
+#[derive(Copy)]
 pub struct Signature([c_uchar; 64]);
 impl_array_newtype!(Signature, c_uchar, 64);
 impl_raw_debug!(Signature);
@@ -176,6 +178,7 @@ impl Signature {
 }
 
 #[repr(C)]
+#[derive(Copy)]
 pub struct XOnlyPublicKey([c_uchar; 64]);
 impl_array_newtype!(XOnlyPublicKey, c_uchar, 64);
 impl_raw_debug!(XOnlyPublicKey);

secp256k1-sys/src/macros.rs

@@ -68,8 +68,6 @@ macro_rules! impl_array_newtype {
             pub fn is_empty(&self) -> bool { false }
         }
 
-        impl Copy for $thing {}
-
         impl Clone for $thing {
             #[inline]
             fn clone(&self) -> $thing {
@@ -167,7 +165,7 @@ macro_rules! impl_raw_debug {
     ($thing:ident) => {
         impl ::core::fmt::Debug for $thing {
             fn fmt(&self, f: &mut ::core::fmt::Formatter) -> ::core::fmt::Result {
-                for i in self[..].iter().cloned() {
+                for i in &self[..] {
                     write!(f, "{:02x}", i)?;
                 }
                 Ok(())

secp256k1-sys/src/recovery.rs

@@ -20,6 +20,7 @@ use {Context, Signature, NonceFn, PublicKey};
 
 /// Library-internal representation of a Secp256k1 signature + recovery ID
 #[repr(C)]
+#[derive(Copy)]
 pub struct RecoverableSignature([c_uchar; 65]);
 impl_array_newtype!(RecoverableSignature, c_uchar, 65);
 impl_raw_debug!(RecoverableSignature);

src/lib.rs

@@ -458,6 +458,7 @@ impl<'de> ::serde::Deserialize<'de> for Signature {
 }
 
 /// A (hashed) message input to an ECDSA signature
+#[derive(Copy)]
 pub struct Message([u8; constants::MESSAGE_SIZE]);
 impl_array_newtype!(Message, u8, constants::MESSAGE_SIZE);
 impl_pretty_debug!(Message);

src/schnorrsig.rs

@@ -16,6 +16,7 @@ use {Message, Signing, Verification};
 use SecretKey;
 
 /// Represents a Schnorr signature.
+#[derive(Copy)]
 pub struct Signature([u8; constants::SCHNORRSIG_SIGNATURE_SIZE]);
 impl_array_newtype!(Signature, u8, constants::SCHNORRSIG_SIGNATURE_SIZE);
 impl_pretty_debug!(Signature);