Test cases for display_secret

Author: dr-orlovsky

src/key.rs

@@ -689,11 +689,10 @@ mod test {
         let pk = PublicKey::from_slice(&[0x02, 0x18, 0x84, 0x57, 0x81, 0xf6, 0x31, 0xc4, 0x8f, 0x1c, 0x97, 0x09, 0xe2, 0x30, 0x92, 0x06, 0x7d, 0x06, 0x83, 0x7f, 0x30, 0xaa, 0x0c, 0xd0, 0x54, 0x4a, 0xc8, 0x87, 0xfe, 0x91, 0xdd, 0xd1, 0x66]).expect("pk");
         let mut buf = [0u8; constants::SECRET_KEY_SIZE * 2];
 
-        #[allow(deprecated)] {
         assert_eq!(
             to_hex(&sk[..], &mut buf).unwrap(),
             "01010101010101010001020304050607ffff0000ffff00006363636363636363"
-        ) };
+        );
         assert_eq!(
             SecretKey::from_str("01010101010101010001020304050607ffff0000ffff00006363636363636363").unwrap(),
             sk

src/lib.rs

@@ -853,8 +853,8 @@ fn from_hex(hex: &str, target: &mut [u8]) -> Result<usize, ()> {
 }
 
 /// Utility function used to encode hex into a target u8 buffer. Returns
-/// a reference to the target buffer as an str.
-// it returns an error if the target buffer isn't big enough
+/// a reference to the target buffer as an str. Returns an error if the target
+/// buffer isn't big enough
 #[inline]
 fn to_hex<'a>(src: &[u8], target: &'a mut [u8]) -> Result<&'a str, ()> {
     let hex_len = src.len() * 2;

src/secret.rs

@@ -58,8 +58,14 @@ macro_rules! impl_display_secret {
 /// ```
 /// use secp256k1::key::ONE_KEY;
 /// let key = ONE_KEY;
-/// println!("{}", key.display_secret());
-/// println!("{:?}", key.display_secret());
+/// assert_eq!(
+///     "0000000000000000000000000000000000000000000000000000000000000001",
+///     format!("{}", key.display_secret())
+/// );
+/// assert_eq!(
+///     "[0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1]",
+///     format!("{:?}", key.display_secret())
+/// );
 /// ```
 ///
 /// [`Display`]: fmt::Display
@@ -119,3 +125,24 @@ impl KeyPair {
     }
 }
 */
+
+#[cfg(test)]
+mod test {
+    use key::ONE_KEY;
+
+    #[test]
+    pub fn secret_key_display() {
+        assert_eq!(
+            ONE_KEY.display_secret().to_string(),
+            "0000000000000000000000000000000000000000000000000000000000000001"
+        );
+    }
+
+    #[test]
+    pub fn secret_key_debug() {
+        assert_eq!(
+            &format!("{:?}", ONE_KEY.display_secret()),
+            "[0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1]"
+        );
+    }
+}